Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change NavRail position to center on large screen #1027

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Change NavRail position to center on large screen #1027

merged 3 commits into from
Sep 11, 2024

Conversation

nyagasan
Copy link
Contributor

Issue

  • On devices with large screens, the NavRail was positioned in the upper left corner.
  • On foldable devices, the size of the NavRail seemed small.

Overview (Required)

  • NavRail height changed to 420 dp.
  • NavRail centered vertically on the left side of the screen.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

@github-actions GitHub Actions
Copy link

Detekt check failed. Please run ./gradlew detekt --auto-correct to fix the issues.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 10, 2024 11:37 Inactive
@github-actions GitHub Actions
Copy link

Snapshot diff report

File name Image
GlassLikeNavRailPrev
iew_compare.png

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 10, 2024 16:32 Inactive
@takahirom
Copy link
Member

Looks great! Thank you!

@takahirom takahirom merged commit 39ac19d into DroidKaigi:main Sep 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nyagasan @takahirom