Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Addressed Gradle Cache issues. #744

Conversation

Corvus400
Copy link
Contributor

@Corvus400 Corvus400 commented Aug 22, 2024

Issue

Overview (Required)

  • We added configuration to mark KspTaskNative and KotlinNativeLink tasks as incompatible with Gradle's Configuration Cache.
  • This change ensures that these specific tasks are always executed without using the Configuration Cache, allowing the ./gradlew assembleSharedXCFramework and ./gradlew iosSimulatorArm64AggregateResources tasks to run successfully without requiring the --no-configuration-cache option.

Background

  • In the previous code, the KspTaskNative and KotlinNativeLink tasks were not explicitly marked as incompatible with the Configuration Cache.
  • These tasks rely on dynamic evaluation during the configuration phase, particularly when referencing system properties, which led to issues when the Configuration Cache was enabled. As a result, builds would fail unless the --no-configuration-cache option was specified.

Changes

  • We added the notCompatibleWithConfigurationCache("Configuration cache not supported for a system property read at configuration time") setting to these specific tasks.
  • This configuration only affects the KspTaskNative and KotlinNativeLink tasks, ensuring they are executed without the Configuration Cache.
  • All other tasks that are compatible with the Configuration Cache will continue to benefit from its use, maintaining efficient build times.

  • Thanks to @Aniokrait for providing specific ways to respond! 👏

Links

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 22, 2024 19:14 Inactive
…github.com:Corvus400/conference-app-2024 into bug/fix_build_failes_just_compile_gradle_cache_problem
…github.com:Corvus400/conference-app-2024 into bug/fix_build_failes_just_compile_gradle_cache_problem
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 23, 2024 18:38 Inactive
…github.com:Corvus400/conference-app-2024 into bug/fix_build_failes_just_compile_gradle_cache_problem
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 23, 2024 21:53 Inactive
…github.com:Corvus400/conference-app-2024 into bug/fix_build_failes_just_compile_gradle_cache_problem
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 24, 2024 03:02 Inactive
…github.com:Corvus400/conference-app-2024 into bug/fix_build_failes_just_compile_gradle_cache_problem
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 24, 2024 03:50 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 24, 2024 03:56 Inactive
@Corvus400 Corvus400 marked this pull request as ready for review August 24, 2024 04:17
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks.

@takahirom takahirom merged commit 05afc38 into DroidKaigi:main Aug 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Gradle cache problem] Bug, Build fails to kover on just compile.
2 participants