Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent result of s3fs::s3_dir_create with fs::dir_create #28

Closed
reisfe opened this issue Aug 20, 2023 · 5 comments
Closed

Inconsistent result of s3fs::s3_dir_create with fs::dir_create #28

reisfe opened this issue Aug 20, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@reisfe
Copy link

reisfe commented Aug 20, 2023

When the directory already exists, fs::dir_create ignores it and returns the path(s) to the directory(ies), while s3fs::s3_dir_create returns the string "Directory already exists in AWS S3".

If the goal is to make code written using the fs package portable to the s3fs than the behavior of the functions should be as close as possible.

Also, returning a string is not the most common behavior in R. A condition should be raised, either error, warning or message.

@DyfanJones
Copy link
Owner

That is a fair point, I will look at implementing improvements after completing paws performance paws-r/paws#621

@DyfanJones
Copy link
Owner

In the meantime I welcome any PRs :) they help me greatly when I judge my open source packages 😄

@DyfanJones DyfanJones mentioned this issue Oct 23, 2023
@DyfanJones DyfanJones added the bug Something isn't working label Oct 23, 2023
@DyfanJones
Copy link
Owner

Sorry for the delay in this. PR #30 addresses issue. I will release it to the cran shortly

@reisfe
Copy link
Author

reisfe commented Oct 23, 2023

Great!
Thank you.
(And thank you for the great package.)

@DyfanJones
Copy link
Owner

Closing as s3fs 0.1.4 has been released to the cran

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants