Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undeclared dependency on R version >= 3.6.0 #29

Closed
tyner opened this issue Sep 29, 2023 · 5 comments
Closed

undeclared dependency on R version >= 3.6.0 #29

tyner opened this issue Sep 29, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@tyner
Copy link

tyner commented Sep 29, 2023

Some functions in the s3fs package make use of base::trimws with the whitespace argument. However, that argument is not available prior to R version 3.6.0.

So in older R versions:

foo <- s3_dir_ls("s3://foo/bar")

gives:

Error in trimws(path, which = "right", whitespace = "/") : 
  unused argument (whitespace = "/")
@DyfanJones
Copy link
Owner

Ah sorry about that. I guess I should include the package backport to ensure that all functions are available for old versions of R. I am currently on holiday at the moment, so will tackle this when I get back :) in the mean time I am open to any PRs :)

@tyner
Copy link
Author

tyner commented Sep 29, 2023

Rather than add a dependency on another package, my personal preference would be to explicitly declare the version dependency and move on.

@DyfanJones
Copy link
Owner

That is fair :)

@DyfanJones DyfanJones mentioned this issue Oct 23, 2023
@DyfanJones DyfanJones added the bug Something isn't working label Oct 23, 2023
@DyfanJones
Copy link
Owner

Sorry for the delay in this. PR #30 addresses issue. I will release it to the cran shortly

@DyfanJones
Copy link
Owner

Closing as s3fs 0.1.4 has been released to the cran

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants