-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic unit testing #49
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
joshuabmoore
commented
Jan 22, 2024
- I've added a GitHub workflows folder with a Git Actions .yaml which will create a virtual Linux environment in which to test pyspi via. pytest unit tests. The tests currently run in a an Ubuntu environment with python 3.8. Caching of the pip dependencies was also used to speed up testing. Some minor changes were made to the dependencies pulled from the requirements.txt file to overcome the commonly encountered pandas issue on Linux. In particular, we modify the pandas and numpy versions to 1.3.3 and 1.22.0, respectively. The motivation here was to find a workaround without having to modify the original requirements.txt file which may have unintended ramifications for Windows/Mac users. This seems to resolves the pandas error for Linux systems.
- Added a standard normal dataset to the 'data' folder in preparation for SPI unit testing (next step).
- A tests folder which will contain all of the unit test code, including unit basic unit tests for the calculator and data objects (e.g., does instantiate?). Next step will be to incorporate SPI unit tests, however this may require a bit more nuance (particularly with stochastic SPIs/inconsistent outputs, skipping tests for SPIs that don't compute for whatever reason, etc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.