Skip to content

Commit

Permalink
build: Fix clang warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
vasylskorych committed Jun 20, 2024
1 parent 829e18a commit 707b9ee
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion GUIDialogs/UnitsViewer/PlotsViewer.h
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class CPlotsViewer

public slots:
void UpdateWholeView();
void setVisible( bool _bVisible );
void setVisible( bool _bVisible ) override;

private slots:
void SliderPositionChanged( int _nIndex );
Expand Down
4 changes: 2 additions & 2 deletions GUIDialogs/UnitsViewer/UnitsViewer.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class CUnitsViewer

public:
CUnitsViewer(CFlowsheet* _pFlowsheet, CMaterialsDatabase* _materialsDatabase, QWidget* _parent = nullptr, Qt::WindowFlags flags = Qt::WindowFlags());
~CUnitsViewer();
~CUnitsViewer() override;

void SetPointers(CModelsManager* _modelsManager, QSettings* _settings) override;
void InitializeConnections();
Expand Down Expand Up @@ -71,5 +71,5 @@ private slots:

public slots:
void UpdateWholeView();
void setVisible( bool _bVisible );
void setVisible( bool _bVisible ) override;
};
4 changes: 4 additions & 0 deletions Utilities/DisableWarningHelper.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
#define PRAGMA_WARNING_PUSH __pragma(warning(push))
#define PRAGMA_WARNING_POP __pragma(warning(pop))
#define PRAGMA_WARNING_DISABLE __pragma(warning(disable : 4005 4244 4267 4700 ALL_CODE_ANALYSIS_WARNINGS))
#elif defined(__clang__)
#define PRAGMA_WARNING_PUSH _Pragma("clang diagnostic push")
#define PRAGMA_WARNING_POP _Pragma("clang diagnostic pop")
#define PRAGMA_WARNING_DISABLE _Pragma("clang diagnostic ignored \"-Winconsistent-missing-override\"")
#else
#define PRAGMA_WARNING_PUSH
#define PRAGMA_WARNING_POP
Expand Down

0 comments on commit 707b9ee

Please sign in to comment.