-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/private submission #21
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Massive work for a ridiculous problem... Thank you lots V.
I think that as long as it works let's keep it like this until we know for certain that we need to reimplement it with the new webin-cli (unless we recycle this code for the assembly_uploader?). But for the future I'd suggest:
- Reformat all URLs as constants (also the one below, in the genome submission part)
- Write functions for post/get requests and data parsing/processing
- This could include writing a set of constants for exceptions
But again... I'd leave this for now
…me upload script, redfine ena functions
New changes! @Ge94 @mberacochea
The end-to-end test doesn't work locally. Seems to be fine on GitHub .. it's failing locally at the submission of the samples with a Forbidden error. I suspect it's a credential thing but I'm not sure how you got around this before? |
This is not to be merged. It is just a review for the first part change of the code so you don't get a massive batch of changes to review at once. This change solely tackles the API endpoints. Any comments on cleaner coding would be good. I will tackle the exceptions and tests in a later review.
Logic:
--private is an input parameter
Public - portal API search endpoints with no authentication.
Private: