Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2051] Core Plugin Audit #2083

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

Rixxan
Copy link
Contributor

@Rixxan Rixxan commented Oct 19, 2023

Broken out of #2068

Description

This is a full-pass update to the core plugin files, containing a major SemVer-compliant logic overhaul to the files. These updates are intended to optimize existing code, update older Python 2 style code to more updated standards, and increase readability and compatibility.

Type of change

  • Rewrite of Existing Code

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Multiple install runs, clean installs, self-updates, and others made to confirm functionality, including under a variety of existing pre-install situations.
  • All PyTest tests pass
  • Tested by the EDMC Internal Alpha Group and initial bugs fixed.

@Rixxan Rixxan added Plugins Anything related to plugins code cleanup Cleaning up code python Pull requests that update Python code labels Oct 19, 2023
@Rixxan Rixxan added this to the 5.10.0 milestone Oct 19, 2023
@Rixxan Rixxan requested a review from C1701D October 19, 2023 21:48
@Rixxan Rixxan self-assigned this Oct 19, 2023
Copy link
Member

@C1701D C1701D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@C1701D C1701D merged commit ff668ea into EDCD:develop Oct 19, 2023
1 check passed
@C1701D C1701D deleted the enhancement/2051/plugins branch October 19, 2023 23:02
@Athanasius
Copy link
Contributor

Slightly strange choice there to regress from dict to Dict on types, and e.g. str | None to Optional[str]. That's going from the newer forms to the older. The idea is to have to import less from typing, not more. Things like Dict and Optional were necessary in typing before proper support was added in later Python versions.

@Rixxan Rixxan linked an issue Dec 1, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Cleaning up code Plugins Anything related to plugins python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit Existing Code - Non Breaking Updates
3 participants