Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to refresh non Check-in users #116

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

enolfc
Copy link
Contributor

@enolfc enolfc commented Jan 8, 2024

Summary

Users created manually won't have access tokens or refresh tokens and therefore will fail to refresh. Detect this situation so we can have some stress tests in place.

Probably should check the validity of the access token instead of this refresh_info that is created after successful call of this function.


Related issue :

Copy link
Contributor

@valtri valtri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tested token refresh in testing environment. 👍

@enolfc enolfc merged commit db30657 into EGI-Federation:main Jan 9, 2024
3 checks passed
@enolfc enolfc deleted the better-refresh branch January 9, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants