jwt #119
Merged
jwt #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of hardcoded stuff and assumptions, but works as expected. It can
be run as a service with a config like this
```
c.JupyterHub.load_roles = [
{
"name": "jwt",
"scopes": [
"read:users:activity", # read user last_activity
"servers", # start and stop servers
"admin:users", # needed if culling idle users as well
],
},
{
"name": "user",
"scopes": ["access:services", "self"],
},
]
c.JupyterHub.services = [
{
"name": "jwt",
"url": "http://localhost:1984/",
# any secret >8 characters, you'll use api_token to
# authenticate api requests to the hub from your service
"api_token": "super-secret",
}
]
```
and then start the service:
```
fastapi dev --port 1984 api_wrapper.py
```
Also remove some unneeded code
|
This is ready for a first review and then deployment in devel/staging. We can refine it later as we test it out. |
andrea-manzi
approved these changes
Jun 13, 2024
|
I'm merging so we have new docker images and we can properly test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
JWT authentication and an API wrapper capable of from a JWT token call the hub API with a valid internal hub token and return results.
The JWT authentication extends the
egiauthenticatorwith a new handler listening at/jwt_loginthat when sent a valid JWT token it will authenticate the user as with the regular code grant based authentication and return a JSON like this:This could be used by an API client directly to perform any subsequent calls.
In the EOSC procurement node we add an additional wrapper so the client is not aware of the internal hub token. This wrapper will forward any call to the hub API and will attempt to authenticate with a JWT and use the returned token for the API call. The wrapper is a simple fastAPI application that can be run as a service of the Hub:
What's missing:
Related issue :