jwt settings #122
Merged
jwt settings #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead show a 403 error, that looks better
egi_notebooks_hub/d4science.py
Outdated
| @@ -188,11 +188,12 @@ async def get_resources(self, access_token): | |||
| async def authenticate(self, handler, data=None): | |||
| # first get authorized upstream | |||
| user_data = await super().authenticate(handler, data) | |||
| context = quote_plus(getattr(self, "d4science_context", None)) | |||
| context = getattr(self, "d4science_context", None) | |||
There was a problem hiding this comment.
i guess this will need to be updated when this is merged #117
|
The code is working (except the known missing parts, which can go in another PR). So it could be approved. What about the D4Science part? Is this PR safe to merge? |
andrea-manzi
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make the API wrapper configurable so it runs beyond the simple local scenario
Related issue :