Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create usernames on the fly for service accounts #136

Merged
merged 9 commits into from
Sep 27, 2024

Conversation

enolfc
Copy link
Contributor

@enolfc enolfc commented Sep 24, 2024

Summary

Assume the user can somehow be authorized afterwards. Potentially we could look for an alternative attribute instead of sub as fallback.


Related issue :

Copy link
Contributor

@andrea-manzi andrea-manzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @valtri can you also try on testing?

This will ensure that we are refreshing before the next call to refresh
for tokens that are about to expire.
@enolfc enolfc marked this pull request as ready for review September 27, 2024 10:00
Copy link
Contributor

@valtri valtri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@valtri valtri merged commit df106d8 into EGI-Federation:main Sep 27, 2024
3 checks passed
@enolfc enolfc deleted the service-account branch September 27, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants