-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fedcloud secrets #347
Use fedcloud secrets #347
Conversation
Instead use fedcloud secret command with a locker that can only be used 2 times (one for putting the secret, another for getting it) and for 1 hour max.
Instead of having this externally managed as it is a pain to update and to keep properly aligned
Lots of testing happened here: #344 |
Terraform Format and Style 🖌
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (but mostly blind/direct approval to not block things, maybe it would be good to have some more people as reviewers of this)
Ansible deployment:
|
* Do not send long lived secrets to VM Instead use fedcloud secret command with a locker that can only be used 2 times (one for putting the secret, another for getting it) and for 1 hour max. * Move the ansible role to this repository Instead of having this externally managed as it is a pain to update and to keep properly aligned * Move to the embedded role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just going through this PR now...
ams_token: secret | ||
|
||
# check-in endpoint | ||
checkin_token_endpoint: "https://aai.egi.eu/oidc/token" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legacy config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, an additional comment
REFRESH_TOKEN: ${{ secrets.REFRESH_TOKEN }} | ||
ANSIBLE_SECRETS: ${{ secrets.ANSIBLE_SECRETS }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I guess these secrets should be directly stored in https://secrets.egi.eu/ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, although I don't know yet what's the best way of dealing with this, any ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
following up internally :)
Summary
Change the approach for managing records, avoiding sending the long lived ones in cloud-init. At the same time move the ansible role to this repository instead of relying on a external role (EGI-Federation/ansible-role-fedcloud-ops) that makes no sense as an independent thing.
Related issue : 341