Code review for Habib and Fanan (by Enrico Cestaro) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnricoCestaro
changed the title
EnricoCestaro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need 3 classes and 2 small interfaces to be reviewed. They are part of the storage library, it allows the user to convert, save and load different objects inside the Android Internal Storage.
The files which need a review are:
storagelibrary -> InternalMemoryStorage
storagelibrary -> JsonConverter
storagelibrary -> PollListStoring
storagelibrary -> PollStoring
storagelibrary -> StoringJasons
The library converts TernaryPoll objects, the class is inside of the library but it wasn't created by me, so it can be ignored with the Poll class