Skip to content

Commit

Permalink
Merge pull request #446 from GSuma21/login_security_changes
Browse files Browse the repository at this point in the history
Login security changes
  • Loading branch information
Cafnanc committed Mar 26, 2024
2 parents 48ea6bb + 6b05abc commit 55f6a93
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 18 deletions.
6 changes: 4 additions & 2 deletions src/app/pages/auth/login/login.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,13 @@ export class LoginPage implements OnInit {
position: 'floating',
errorMessage:{
required: "Enter password",
minlength: "Password should contain minimum of 8 characters"
minlength:environment.password.minLength ? "Please enter minimum " + environment.password.minLength+" characters.":"Please enter minimum 8 characters.",
pattern: environment.password.errorMessage ? environment.password.errorMessage :"Only letters, numbers,!@#%$&()-`.+,/\" are allowed",
},
validators: {
required: true,
minLength: 8,
minLength:environment.password.minLength? environment.password.minLength: 8,
pattern: environment.password.rejectPattern ? environment.password.rejectPattern :"^[a-zA-Z0-9!@#%$&()\\-`.+,/\"]*$",
},
},
],
Expand Down
17 changes: 9 additions & 8 deletions src/app/pages/auth/register/register.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { ActivatedRoute, Router } from '@angular/router';
import { CommonRoutes } from 'src/global.routes';
import { TranslateService } from '@ngx-translate/core';
import { ProfileService } from 'src/app/core/services/profile/profile.service';
import { environment } from 'src/environments/environment';

@Component({
selector: 'app-register',
Expand Down Expand Up @@ -60,13 +61,13 @@ export class RegisterPage implements OnInit {
position: 'floating',
errorMessage:{
required: "Enter password",
minlength:"Please enter minimum 8 characters.",
pattern:"Only letters, numbers,!@#%$&()-`.+,/\" are allowed"
minlength:environment.password.minLength ? "Please enter minimum " + environment.password.minLength+" characters.":"Please enter minimum 8 characters.",
pattern: environment.password.errorMessage ? environment.password.errorMessage :"Only letters, numbers,!@#%$&()-`.+,/\" are allowed",
},
validators: {
required: true,
minLength: 8,
pattern: "^[a-zA-Z0-9!@#%$&()\\-`.+,/\"]*$",
minLength:environment.password.minLength? environment.password.minLength: 8,
pattern: environment.password.rejectPattern ? environment.password.rejectPattern :"^[a-zA-Z0-9!@#%$&()\\-`.+,/\"]*$",
},
},
{
Expand All @@ -78,13 +79,13 @@ export class RegisterPage implements OnInit {
position: 'floating',
errorMessage:{
required: "Re-enter password",
minlength:"Please enter minimum 8 characters.",
pattern:"Only letters, numbers,!@#%$&()-`.+,/\" are allowed"
minlength:environment.password.minLength ? "Please enter minimum " + environment.password.minLength+" characters.":"Please enter minimum 8 characters.",
pattern: environment.password.errorMessage ? environment.password.errorMessage :"Only letters, numbers,!@#%$&()-`.+,/\" are allowed",
},
validators: {
required: true,
minLength: 8,
pattern: "^[a-zA-Z0-9!@#%$&()\\-`.+,/\"]*$",
minLength: environment.password.minLength ? environment.password.minLength:8,
pattern: environment.password.rejectPattern ? environment.password.rejectPattern :"^[a-zA-Z0-9!@#%$&()\\-`.+,/\"]*$",
}
}
]
Expand Down
17 changes: 9 additions & 8 deletions src/app/pages/auth/reset-password/reset-password.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { Router } from '@angular/router';
import { ProfileService } from 'src/app/core/services/profile/profile.service';
import { ToastService } from 'src/app/core/services';
import { TranslateService } from '@ngx-translate/core';
import { environment } from 'src/environments/environment';

@Component({
selector: 'app-reset-password',
Expand Down Expand Up @@ -40,14 +41,14 @@ export class ResetPasswordPage implements OnInit {
type: 'password',
errorMessage:{
required: "Enter new password",
minlength:"Please enter minimum 8 characters.",
pattern:"Only letters, numbers,!@#%$&()-`.+,/\" are allowed"
minlength:environment.password.minLength ? "Please enter minimum " + environment.password.minLength+" characters.":"Please enter minimum 8 characters.",
pattern: environment.password.errorMessage ? environment.password.errorMessage :"Only letters, numbers,!@#%$&()-`.+,/\" are allowed",
},
position: 'floating',
validators: {
required: true,
minLength: 8,
pattern: "^[a-zA-Z0-9!@#%$&()\\-`.+,/\"]*$",
minLength:environment.password.minLength? environment.password.minLength: 8,
pattern: environment.password.rejectPattern ? environment.password.rejectPattern :"^[a-zA-Z0-9!@#%$&()\\-`.+,/\"]*$",
},
},
{
Expand All @@ -58,14 +59,14 @@ export class ResetPasswordPage implements OnInit {
type: 'password',
errorMessage:{
required: "Re-enter new password",
minlength:"Please enter minimum 8 characters.",
pattern:"Only letters, numbers,!@#%$&()-`.+,/\" are allowed"
minlength:environment.password.minLength ? "Please enter minimum " + environment.password.minLength+" characters.":"Please enter minimum 8 characters.",
pattern: environment.password.errorMessage ? environment.password.errorMessage :"Only letters, numbers,!@#%$&()-`.+,/\" are allowed",
},
position: 'floating',
validators: {
required: true,
minLength: 8,
pattern: "^[a-zA-Z0-9!@#%$&()\\-`.+,/\"]*$",
minLength:environment.password.minLength? environment.password.minLength: 8,
pattern: environment.password.rejectPattern ? environment.password.rejectPattern :"^[a-zA-Z0-9!@#%$&()\\-`.+,/\"]*$",
},
},
],
Expand Down

0 comments on commit 55f6a93

Please sign in to comment.