Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issues we spoke about on Matrix (and some more) #15

Open
bovine3dom opened this issue Feb 2, 2021 · 0 comments
Open

Potential issues we spoke about on Matrix (and some more) #15

bovine3dom opened this issue Feb 2, 2021 · 0 comments

Comments

@bovine3dom
Copy link
Collaborator

tridactyl/tridactyl#789 is too big to be useful but is related.

  1. I don't think the parser should interfere with searches as far as possible, e.g.
:tabopen what does nim -c do?
:tabopen video editors "linux"

should both work. I think we'd already discussed not using " in 789 for quoting in the parser - we may have settled on backticks instead?

This would break "just add a -c to change container at the end of a tabopen command". I think the happiest solution is probably to have it configurable? I suspect @ELLIOTTCABLE will dislike the idea of excmd.js having dialects ... I could eventually be persuaded that [flags go here] -- [flags don't go here] is an acceptable solution.

  1. If we move internally to excmd(arg_object), we should make a proxy so that tri.excmds.func(a,b,c) calls func(arg_object) by using the parser to break fewer :js scripts

  2. winopen -private should either (my preference) still work or throw a loud error and not be stored in history to prevent private things being opened in non-private windows with all the drama that could entail

  3. Something that didn't come up in Matrix but I still care quite a lot about: if we aren't pre-registering commands how can we get information for completions out of the parser? Essentially we want the parser to know that tabopen -c [something] will be opening a container and to tell the command line to open container completions. At the moment we essentially have a completely separate parser for this (and can't offer completions within completions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant