-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MOOSE segmentation JSON (dataset.json) format support directly #16
base: main
Are you sure you want to change the base?
Conversation
Hi @prabathbr, cool idea. However, I would prefer to keep this as generic as possible and not steering it towards moose. 😄 |
Thanks, I have made this additional tag "False" as default so that it would work normal if Would it be possible to merge this ? I thought it would be a nice option to have when MOOSE is used in the upstream with nifti2dicom, so that no external script is required to to parse MOOSE output JSON before feeding to nifit2dicom. 😄 |
I see/understand your point, I did discuss with @Keyn34, for his thoughts as well. So, from our perspective, it's not good to add special tags (specific for moose) when we use this for 5x tools internally. It's just a design choice. Also the conversion is simple - we don't need an extra tag. Sorry. |
Hey @prabathbr, thank you for raising this and your input. We want to keep our tools as simple, stand-alone and encapsulated as possible. Although I understand your rationale, it would introduce a higher complexity in maintaining the tools as they would gradually become co-dependent. I suggest building an interface tailored towards your demand. This is what I usually do when I want to use tools subsequently and intertwine. :) That way, you also have better control and can adjust things as you see fit. Thank you for your effort, and I hope our perspective is understandable. :) |
Thank you very much for the insight. |
This patch will use dataset.json from a MOOSE segmentation directly. It will convert the input JSON data to suit nifti2dicom input JSON format on the fly.
Usage:
Added new argument "-m" or "--moose", conversion will apply when it is true.
-m True
Sample Input dataset.json :
Sample conversion at organ_index: