Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance HighlightElements command to be able to assign different colors for highlighted elements #89

Merged
merged 20 commits into from
Aug 8, 2024

Conversation

tlorantfy
Copy link
Collaborator

@tlorantfy tlorantfy commented Jul 23, 2024

I tried 3 solutions:

  1. Rename 'elements' input parameter to 'elementsWithColors' and that array would contain elementId+color pairs.
  2. Change 'highlightedColor' input parameter to array and rename it to 'highlightedColors'. This way the size of this array must match the size of the elements array. So the color of elements[i] would be highlightedColors[i].
  3. Make 'highlightedColorsOfElements' input parameter which would define a color for a group of elements, so that array would define color+elements pairs. This way it's easier to group elements with the same color.

At first I implemented the 1st solution in C++, but I found it hard to use in tapir_py/core.py, so finally I chose the 2nd solution.

From C++ point of view, each has almost the same complexity.
Which would our python developers choose?

@tlorantfy
Copy link
Collaborator Author

@kovacsv, is there any reason why this pull request is not merged yet?
Please tell me if you have any questions or concerns

@kovacsv
Copy link
Collaborator

kovacsv commented Aug 8, 2024

@tlorantfy sorry for the delay, thank you for the contribution!

@kovacsv kovacsv merged commit 77e1f35 into ENZYME-APD:main Aug 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants