Feature/#11 메뉴 정보 입력 페이지 기능을 구현한다. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JJongmen
commented
Feb 15, 2024
| @@ -108,6 +114,8 @@ fun TextTitle( | |||
| description?.let { append(description) } | |||
| } | |||
| }, | |||
| style = MaterialTheme.typography.titleSmall, | |||
There was a problem hiding this comment.
Text 컴포저블 사용할 때 서체를 사용할 수 있더라구
서체 사용하면 fontWeight, fontSize, lineHeight, letterSpacing 이 이미 정의되어있는거라 일일히 지정하는 귀찮음을 없앨 수 있어서 적극활용해보면 좋을듯
Comment on lines
+182
to
+183
| keyboardType: KeyboardType = KeyboardType.Text, | ||
| isError: Boolean = false, |
There was a problem hiding this comment.
KeyboardType.Number 로 인자 넘기면 숫자 키보드 사용할 수 있어.
isError는 사용자가 잘못된 입력을 했을 때 true로 넘겨주면 테두리가 빨간색으로 변해
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot
검증
추가, 삭제, 네비게이션
아까 말한대로
OutlinedTextField활용해서 기존InputTextBox내부 구현 변경했어.근데
OutlinedTextField는 최소한의 높이를 충족 못시키면 글자가 덜 보여서 좀 높이가 높아져버림;;서버로 메뉴 전송하는 것은 서버측 API 구현 완료된 시점에 구현할게.
우선
InputMenuScreen에 모든 기능들이 다 있고 리팩터링해야 하는데 추가하거나 변경될 코드가 많아질 것 같아서MVVM 구조로 리팩터링 하는 이슈 만들어서 리팩터링해볼게.
확인해보고 리뷰점