Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#72, #73 메인 페이지 디자인과 기능을 구현한다 #74

Merged
merged 2 commits into from
May 27, 2024
Merged

Feature/#72, #73 메인 페이지 디자인과 기능을 구현한다 #74

merged 2 commits into from
May 27, 2024

Conversation

johnhuh619
Copy link
Collaborator

Issue

Overview (Required)

  • 메인 페이지 부족한 기능과 디자인 추가
  • 원형을 통해 진행률 파악 가능

Links

Screenshot

Before After

@johnhuh619 johnhuh619 self-assigned this May 23, 2024
@johnhuh619 johnhuh619 added the enhancement New feature or request label May 23, 2024
JJongmen
JJongmen approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@JJongmen JJongmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메인 화면이 든든해져서 좋네

app/src/main/java/com/erica/gamsung/core/presentation/MainScreen.kt
Comment on lines +154 to +156
Color(0xFF3399FF),
Color(0xFF33CCFF),
Color(0xFF3399FF),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헥스코드 Color.kt에 선언하고 쓰는 것도 좋을듯

@johnhuh619 johnhuh619 merged commit 0e56fe8 into main May 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JJongmen JJongmen JJongmen approved these changes

Assignees

@johnhuh619 johnhuh619

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

메인 페이지 기능을 추가하여 구현한다 메인 페이지를 디자인한다
2 participants
@johnhuh619 @JJongmen