Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#79 가게 및 메뉴 입력 화면에서 뒤로 가기 시 설정 화면으로 이동하는 버그를 수정한다 #80

Merged
merged 4 commits into from
May 28, 2024

Conversation

JJongmen
Copy link
Collaborator

@JJongmen JJongmen commented May 28, 2024

Issue

Overview (Required)

  • 가게 및 메뉴 입력 화면에서 뒤로 가기 시 설정 화면으로 이동하는 버그를 수정한다
  • InputMenuViewModel -> MenuViewModel 이름 변경

Links

Screenshot

Before After

@JJongmen JJongmen added bug Something isn't working enhancement New feature or request labels May 28, 2024
@JJongmen JJongmen requested a review from johnhuh619 May 28, 2024 02:05
@JJongmen JJongmen self-assigned this May 28, 2024
@@ -62,7 +62,7 @@ fun InputStoreScreen(
topBar = {
GsTopAppBar(
title = if (isEditMode) "식당 정보 수정" else "식당 정보 입력 (1/2)",
hasLeftIcon = true,
hasLeftIcon = isEditMode,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

입력 화면일때는 뒤로가기 버튼 안보이도록 수정해서 해결함

Comment on lines 61 to 68
onNavigationClick = {
navController.navigate(Screen.Setting.route) {
val toNavigate = if (isEditMode) Screen.Setting else Screen.InputStore(isEditMode = false)
navController.navigate(toNavigate.route) {
launchSingleTop = true
popUpTo(Screen.Setting.route) {
popUpTo(toNavigate.route) {
inclusive = false
}
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

의도대로 수정모드일 때는 설정화면 / 초기 정보 입력 모드일때는 가게 정보 입력화면으로 이동하도록 했어

Copy link
Collaborator

@johnhuh619 johnhuh619 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했어. 문제될 여지는 딱히 없어 보이네

@johnhuh619 johnhuh619 merged commit 4a42a1c into main May 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
2 participants