Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hv pv detection #44

Merged
merged 14 commits into from
Oct 29, 2024
Merged

Hv pv detection #44

merged 14 commits into from
Oct 29, 2024

Conversation

HansVRP
Copy link
Contributor

@HansVRP HansVRP commented Oct 16, 2024

added EURAC UDP.

There are some points which are still open for debate:

  • Do we want to set the max cloud cover as a parameter as well and/or the kernel size of the postprocessing filter?

  • Currently I get the model and dependencies within the UDF, I saw that for world cereal job options are given. Is there a preferred approach?

@soxofaan
Copy link
Contributor

Currently I get the model and dependencies within the UDF, I saw that for world cereal job options are given. Is there a preferred approach?

at the moment there is no standard way to attach job options to UDPs, e.g see this discussion:

so for the moment, I think doing it in the UDF is the only way

@HansVRP
Copy link
Contributor Author

HansVRP commented Oct 17, 2024

In the word cereal benchmark they are passed as:

"job_options": {
"driver-memory": "4g",
"executor-memory": "1500m",
"python-memory": "5g",
"udf-dependency-archives": ["https://artifactory.vgt.vito.be/artifactory/auxdata-public/openeo/onnx_dependencies_1.16.3.zip#onnx_deps"]
}
}

hence my confusion.

Is this then different?

Copy link
Contributor

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some notes

openeo_udp/eurac_pv_farm_detection/generate.py Outdated Show resolved Hide resolved
openeo_udp/eurac_pv_farm_detection/generate.py Outdated Show resolved Hide resolved
@soxofaan
Copy link
Contributor

In the word cereal benchmark they are passed as: ...

ah ok I see what you mean now.

you can indeed define job options in the benchmark scenario

there are indeed two options at the moment

  • handle model/deps "manually" from the UDF code. Adds more boilerplate to the UDF, but makes usage easier (less job_option worries)
  • work with job options. less UDF boilerplate, but as a user you're forced to always set job options. And there is unfortunately no standard way jet to attach "recommended" job options to a UDP

I'm not sure what is best at the moment

@HansVRP HansVRP requested a review from soxofaan October 28, 2024 10:44
@HansVRP HansVRP requested a review from soxofaan October 29, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants