Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add clim_modal_aero logic around aero prop call in cam7 #1207

Open
wants to merge 1 commit into
base: cam_development
Choose a base branch
from
Open

add clim_modal_aero logic around aero prop call in cam7 #1207

wants to merge 1 commit into from

Conversation

adamrher
Copy link

Fixes #626

Shouldn't change answers, since there is no regression test for cam7 -chem none.

@adamrher adamrher added the bug Something isn't working correctly label Dec 11, 2024
@cacraigucar cacraigucar requested a review from fvitt December 17, 2024 16:31
fvitt
fvitt approved these changes Dec 18, 2024
View reviewed changes
Copy link

@fvitt fvitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. Thanks for the fix.

@fvitt
Copy link

fvitt commented Dec 18, 2024

@cacraigucar
Should we consider adding a regression for this, such as:

  SMS_D_Ln9.ne3pg3_ne3pg3_mg37.FLTHIST.izumi_gnu.cam-outfrq9s_nochem

?

@brian-eaton
Copy link
Collaborator

Note that my implementation of the cam7 aquaplanets (PR #1203) fixes this as they use -chem none. They are close to being ready.

@adamrher
Copy link
Author

Thanks @brian-eaton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fvitt fvitt fvitt approved these changes

Assignees
No one assigned
Labels
bug Something isn't working correctly CoupledEval3
Projects
CAM Development
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamrher @fvitt @brian-eaton @cacraigucar