Bug fixes for interpolate_output routines #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nusbaume
added
BFB
Merged
|
closing this PR - was included in cam6_3_081 ( #680 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request contains a few bug fixes for the
interpolate_outputoption for the SE dycore. Specifically, it allows for single-precision (e.g.ndens = 2) interpolated output, and allows for variables with missing values (e.g.AODVIS) to be output correctly in the standard monthly average (h0) files, at least for certain SE-CSLAM grids.Please note however that variables with missing values may still have "bad" values at the missing value margins when either using very high resolution grids or outputting at high frequencies (e.g. every hour or every time step). To fix this issue completely will potentially require a much larger set of code modifications, which might be beneficial to do in conjunction with future developments (e.g. the creation of a dycore-agnostic interpolation routine), hence why I am creating this smaller PR now.
Fixes #644
Partially addresses #564
Was reviewed in #659