Add/modify skin temperature at surface variables. #84
Conversation
svahl991
requested review from
cacraigucar,
climbfuji,
dustinswales,
gold2718,
grantfirl,
mattldawson,
mkavulich,
mwaxmonsky,
nusbaume,
peverwhee,
MayeulDestouches and
ss421
as code owners
|
Tagging @travissluka @rtodling @mikecooke77 @fmahebert |
There was a problem hiding this comment.
I believe we use over_ocean instead of over_sea (and we use over_lake; in case we don't need to distinguish, we use over_water). I checked the standard name dictionary, there are two entries with over_ocean and none with over_sea. In the NCAR ccpp-physics repo, there are six entries with over_ocean, but none with over_sea.
This can be changed if there is a good reason to use sea and not ocean - is there?
I will wait a bit for the scientists to chime in. If I don't hear anything I'll change the name in this PR to |
| <standard_name name="skin_temperature_at_surface_over_ice" | ||
| long_name="Skin temperature at surface over (or where) ice"> |
There was a problem hiding this comment.
Is any distinction needed between ice over land and ice over ocean?
There was a problem hiding this comment.
Is any distinction needed between ice over land and ice over ocean?
@travissluka we discussed this in-person and you had some thoughts?
There was a problem hiding this comment.
good point, it's probably best to keep skin_temperature_at_surface_over_ice for when we don't care if it is land ice or ocean ice, and have separate variables for land and ocean.
@svahl991 I don't think we do anything with land ice at the moment (in my world all ice is ocean ice) but distinguishing between the two might be needed in the future
|
@svahl991 Just checking in on the status of this PR, assuming that you're okay with the change of |
|
Thanks for the ping @mkavulich . This fell off my radar. I have now changed "sea" to "ocean" (after consulting with @travissluka ), so hopefully this is good to go now. |
This PR modifies the existing
surface_skin_temperaturename to match the new naming rule introduced in #72. It also adds four new skin temperature variable variants. All these variables were introduced into JEDI during the October 2024 variable naming sprint.Note a small JEDI/CCPP naming discrepancy discussed in #83. I attempted to smooth over this difference in the long name.