Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/modify skin temperature at surface variables. #84

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add/modify skin temperature at surface variables. #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c362362
Add JEDI skin temperature variables
svahl991 Nov 8, 2024
f57fd38
Merge branch 'main' into feature/JCSDA-surface-vars
svahl991 Nov 8, 2024
e0f938a
Add long name to xml
svahl991 Nov 8, 2024
a2e6e5d
Add another long name to xml
svahl991 Nov 8, 2024
fca1e6b
Merge branch 'main' into feature/JCSDA-surface-vars
svahl991 Dec 19, 2024
5d58f1b
Change sea to ocean
svahl991 Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Metadata-standard-names.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1799,9 +1799,15 @@ Variables related to the compute environment
* `real(kind=kind_phys)`: units = cm
* `surface_roughness_length_over_water`: Surface roughness length over water
* `real(kind=kind_phys)`: units = cm
* `surface_skin_temperature`: Surface skin temperature
* `skin_temperature_at_surface`: Skin temperature at surface
* `real(kind=kind_phys)`: units = K
* `surface_skin_temperature_over_land`: Surface skin temperature over land
* `skin_temperature_at_surface_over_ice`: Skin temperature at surface over (or where) ice
* `real(kind=kind_phys)`: units = K
* `skin_temperature_at_surface_over_land`: Skin temperature at surface over (or where) land
* `real(kind=kind_phys)`: units = K
* `skin_temperature_at_surface_over_ocean`: Skin temperature at surface over (or where) ocean
* `real(kind=kind_phys)`: units = K
* `skin_temperature_at_surface_over_snow`: Skin temperature at surface over (or where) snow
* `real(kind=kind_phys)`: units = K
* `surface_snow_area_fraction_over_ice`: Surface snow area fraction over ice
* `real(kind=kind_phys)`: units = fraction
Expand Down
18 changes: 16 additions & 2 deletions standard_names.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2826,10 +2826,24 @@
<standard_name name="surface_roughness_length_over_water">
<type kind="kind_phys" units="cm">real</type>
</standard_name>
<standard_name name="surface_skin_temperature">
<standard_name name="skin_temperature_at_surface"
long_name="Skin temperature at surface">
<type kind="kind_phys" units="K">real</type>
</standard_name>
<standard_name name="surface_skin_temperature_over_land">
<standard_name name="skin_temperature_at_surface_over_ice"
long_name="Skin temperature at surface over (or where) ice">
Comment on lines +2833 to +2834
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is any distinction needed between ice over land and ice over ocean?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is any distinction needed between ice over land and ice over ocean?

@travissluka we discussed this in-person and you had some thoughts?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, it's probably best to keep skin_temperature_at_surface_over_ice for when we don't care if it is land ice or ocean ice, and have separate variables for land and ocean.
@svahl991 I don't think we do anything with land ice at the moment (in my world all ice is ocean ice) but distinguishing between the two might be needed in the future

<type kind="kind_phys" units="K">real</type>
</standard_name>
<standard_name name="skin_temperature_at_surface_over_land"
long_name="Skin temperature at surface over (or where) land">
<type kind="kind_phys" units="K">real</type>
</standard_name>
<standard_name name="skin_temperature_at_surface_over_ocean"
long_name="Skin temperature at surface over (or where) ocean">
<type kind="kind_phys" units="K">real</type>
</standard_name>
<standard_name name="skin_temperature_at_surface_over_snow"
long_name="Skin temperature at surface over (or where) snow">
<type kind="kind_phys" units="K">real</type>
</standard_name>
<standard_name name="surface_snow_area_fraction_over_ice">
Expand Down
Loading