-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FATES API35 parameter file update #2436
Conversation
These failures are already tracked with derecho versions
This will be reverted once issue ESCOMP#2423 has been addressed
To do list on top of the usual list:
|
This also adds a corresponding namelist build unit test and similar test to check that sp mode + spitfire fails
Running |
Merge b4b-dev Some fixes for run_neon that came up in ctsm5.1.dev172. Small bug fix for units of vector format hillslope hydrology. Start adding PLUMBER2 users-mods (NOT functional)
Regression testing is complete and show all expected tests pass B4B on Results: Regression testing on Results: |
@glemieux on the failing test. The clm60 version is marked as failing as well. And it looks like there's a copied version of it. So it probably just needs to have both the clm50 and clm60 version in expected fails. So this looks fine to me. Thanks for pointing it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description of changes
This updates the default FATES parameter file and should be coordinated with NGEET/fates#1128. The fates externals tag updates also brings with it a number of fates scientific updates and bug fixes since tag
sci.1.72.2_api.34.0.0
.This PR also cleans up the expected failures list to remove out-of-date cheyenne fates testmods. It also adds a new test that is expected to fail per #2423.
Finally, it adds build namelist code to make fates hydro and sp mode incompatible for the time being.
Specific notes
Contributors other than yourself, if any: @rgknox
CTSM Issues Fixed (include github issue #):
Fixes #2478
Are answers expected to change (and if so in what way)? Yes, but only for fates. One new expected failure for
aux_clm
that has been added.Any User Interface Changes (namelist or namelist defaults changes)? new fates parameter file, check for a failure condition
Testing performed, if any: standard FATES testing