Add call in case_setup to run CAM python script #4497
Conversation
lizziel
force-pushed
the
case_setup_commands_for_cam
branch
from
a4fc5ba to
149d9e4
Compare
|
************* Module CIME.case.case_setup |
This update is based on existing code for cism but uses a python script rather than a shell script. The update is needed for use with GEOS-Chem chemistry so that run-time configuration files can be copied to the case directory upon case setup. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
lizziel
force-pushed
the
case_setup_commands_for_cam
branch
from
149d9e4 to
de497e2
Compare
lizziel
changed the title
This update requires cime updates at: ESMCI/cime#4497 Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
|
Heads up I force pushed to my branch to change the shell script to python per comments on ESCOMP/CAM#484. |
This avoids a duplicate string formatting warning when using a linter. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
|
I pushed an update to use named strings. I didn't know about that feature in python! |
|
Please fix the github testing error by running: |
|
Will do. I also have suggested updates from @gold2718 in geoschem/CAM#26 which I am going to test out. |
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
|
I pushed an update for compatibility to changes made to the |
|
do |
|
Or you can do:
|
|
All set. I pushed updates applied by black. |
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
lizziel
force-pushed
the
case_setup_commands_for_cam
branch
from
ed3a662 to
627a3bc
Compare
|
Looks good to me - when you are ready to merge take the PR out of draft status. |
|
I am changing this from Draft status to Ready for Review. This PR and the GEOS-Chem in CAM PR (ESCOMP/CAM#484) are dependent on each other so should be merged together. As far as I know there are no remaining TODOs for that PR before merge. |
|
This PR was merged before ESCOMP/CAM#484. This isn't a major issue, except the nightly aux_cime_baselines tests are failing for any test that use cam. They will continue to fail until this cam PR makes it into a |
|
Sorry - I thought that they were ready to merge. |
|
@fvitt requested more changes for the CAM PR. It is a no diff change so could in theory be changed later after GEOS-Chem is merged in to fix the test failing. |
|
@lizziel no worries - we can wait. Thanks |
Revert PR #4497 since it's break all of the cam tests. These changes will be added back in with a different PR. Test suite: By hand Test baseline: Test namelist changes: Test status: [bit for bit, roundoff, climate changing] Fixes [CIME Github issue #] User interface changes?: Update gh-pages html (Y/N)?:
|
@jedwards4b, the GEOS-Chem PR ESCOMP/CAM#484 is in the final test stage. @fvitt is currently running tests and needs this update. Could you two coordinate for making these PR merges happen at the same time? |
The update is needed for use with GEOS-Chem chemistry so that run-time configuration files can be copied to the case directory upon case setup. This PR should be merged along with CAM PR ESCOMP/CAM#484 at the same time.
Test suite: I manually tested on derecho
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]
Fixes [CIME Github issue #] None
User interface changes?: No
Update gh-pages html (Y/N)?: No