Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.13 #2566

Merged
merged 21 commits into from
Nov 29, 2024
Merged

Support Python 3.13 #2566

merged 21 commits into from
Nov 29, 2024

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Oct 24, 2024

Description

Potential roadblock SciTools/iris#6195

Good news! The race to support Python 3.13 is a lot shorter than 3.12, we have the following roadblocks, in the process of unblocking:

That's it! We fixed esgf-pyclient for 3.13 recently (today), and all else goes through!

Prerequisites needs #2395 merged via main merge in d1dc683


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@valeriupredoi valeriupredoi added the installation Installation problem label Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.67%. Comparing base (a4b9737) to head (0ed921f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2566   +/-   ##
=======================================
  Coverage   94.67%   94.67%           
=======================================
  Files         251      251           
  Lines       14302    14302           
=======================================
  Hits        13540    13540           
  Misses        762      762           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valeriupredoi valeriupredoi marked this pull request as draft October 30, 2024 15:06
@valeriupredoi
Copy link
Contributor Author

@ESMValGroup/technical-lead-development-team @trexfeathers @ESadek-MO some very good news wrt ESMValCore and iris=3.11 and Numpy>2 and Python 3.13 - using the release candidate for iris=3.11 we are now fully covered for Numpy>2 and Python 3.13 support - environment solves smoothly, and the tests that fail are the ones I fixed in #2395 (ie all related to Numpy 2.0+ API and functionality/deprecations); am very happy since the transition to both these important dependencies' updates (Numpy and Python, no sweat, iris 😁 ) is all but complete, without having to go though the hell I went through for Python 3.12 support 🥳 🍻

@valeriupredoi valeriupredoi added the iris311 needs iris 3.11 stable release label Nov 5, 2024
@valeriupredoi
Copy link
Contributor Author

iris==3.11 is out as of 10min ago https://anaconda.org/conda-forge/scitools-iris

@valeriupredoi valeriupredoi marked this pull request as ready for review November 11, 2024 15:40
@valeriupredoi
Copy link
Contributor Author

look gents @bouweandela @schlunma - green 🟢 - we good to get in Python 3.13 🥳

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks V!

.github/workflows/run-tests.yml Outdated Show resolved Hide resolved
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, that approval was a bit too early. Let's see if Iris manages to support 3.13. I thought SciTools/iris#6195 made it into the Iris 3.11 release, but apparently it did not.

@valeriupredoi
Copy link
Contributor Author

That's a good find @bouweandela - they should have pinned Python in their conda recipe if 3.13 is a no-go, will ping them myself, see if I can expedite the adoption 🍺

@bouweandela
Copy link
Member

bouweandela commented Nov 12, 2024

Maybe no code changes are needed in Iris to support Python 3.13, since the tests here are all passing fine. Let's keep an eye on that PR and with a bit of luck things will just work.

Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
@valeriupredoi
Copy link
Contributor Author

Maybe no code changes are needed in Iris to support Python 3.13, since the tests here are all passing fine. Let's keep an eye on that PR and with a bit of luck things will just work.

yup, just gonna put that reference in here in the description so it's clear off the bat - am also gonna go ask them, asking never killed anyone, except that guy that asked Henry VIII where was his wife 😁

@valeriupredoi
Copy link
Contributor Author

hey bud @bouweandela have a look at this SciTools/iris#6195 (comment) , that means we good to go with this 🍺

@valeriupredoi
Copy link
Contributor Author

hey bud @bouweandela have a look at this SciTools/iris#6195 (comment) , that means we good to go with this 🍺

@bouweandela let's get this one in, when you have a minute, given ⬆️

@valeriupredoi valeriupredoi added this to the v2.12.0 milestone Nov 28, 2024
@bouweandela bouweandela merged commit 1cf3862 into main Nov 29, 2024
8 checks passed
@bouweandela bouweandela deleted the python313 branch November 29, 2024 08:53
@valeriupredoi
Copy link
Contributor Author

legend @bouweandela many thanks 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Installation problem iris311 needs iris 3.11 stable release
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants