-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.13 #2566
Support Python 3.13 #2566
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2566 +/- ##
=======================================
Coverage 94.67% 94.67%
=======================================
Files 251 251
Lines 14302 14302
=======================================
Hits 13540 13540
Misses 762 762 ☔ View full report in Codecov by Sentry. |
@ESMValGroup/technical-lead-development-team @trexfeathers @ESadek-MO some very good news wrt ESMValCore and iris=3.11 and Numpy>2 and Python 3.13 - using the release candidate for iris=3.11 we are now fully covered for Numpy>2 and Python 3.13 support - environment solves smoothly, and the tests that fail are the ones I fixed in #2395 (ie all related to Numpy 2.0+ API and functionality/deprecations); am very happy since the transition to both these important dependencies' updates (Numpy and Python, no sweat, iris 😁 ) is all but complete, without having to go though the hell I went through for Python 3.12 support 🥳 🍻 |
iris==3.11 is out as of 10min ago https://anaconda.org/conda-forge/scitools-iris |
look gents @bouweandela @schlunma - green 🟢 - we good to get in Python 3.13 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks V!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, that approval was a bit too early. Let's see if Iris manages to support 3.13. I thought SciTools/iris#6195 made it into the Iris 3.11 release, but apparently it did not.
That's a good find @bouweandela - they should have pinned Python in their conda recipe if 3.13 is a no-go, will ping them myself, see if I can expedite the adoption 🍺 |
Maybe no code changes are needed in Iris to support Python 3.13, since the tests here are all passing fine. Let's keep an eye on that PR and with a bit of luck things will just work. |
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
yup, just gonna put that reference in here in the description so it's clear off the bat - am also gonna go ask them, asking never killed anyone, except that guy that asked Henry VIII where was his wife 😁 |
hey bud @bouweandela have a look at this SciTools/iris#6195 (comment) , that means we good to go with this 🍺 |
@bouweandela let's get this one in, when you have a minute, given ⬆️ |
legend @bouweandela many thanks 🍻 |
Description
Potential roadblock SciTools/iris#6195
Good news! The race to support Python 3.13 is a lot shorter than 3.12, we have the following roadblocks, in the process of unblocking:
iris needs be built with numpy>=2 since only numpy>=2 has support for Python 3.13; iris=3.11 is almost out, and that is built with numpy>=2 and 3.13, we need to get in [Numpy2] Support fornumpy==2.0.0
(and piniris >=3.11
) #2395 ourselvesThat's it! We fixed esgf-pyclient for 3.13 recently (today), and all else goes through!
Prerequisites needs #2395merged viamain
merge in d1dc683Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: