From 607c2f50c9aee406e4dfab2bf64ee3582af1ea2b Mon Sep 17 00:00:00 2001
From: Sem <931684+sembrestels@users.noreply.github.com>
Date: Tue, 23 May 2023 21:02:12 +0200
Subject: [PATCH] chore(aragonos): Remove check in upgrade command

---
 .../src/modules/aragonos/commands/upgrade.ts        | 10 +---------
 .../test/modules/aragonos/commands/upgrade.test.ts  | 13 -------------
 2 files changed, 1 insertion(+), 22 deletions(-)

diff --git a/packages/evmcrispr/src/modules/aragonos/commands/upgrade.ts b/packages/evmcrispr/src/modules/aragonos/commands/upgrade.ts
index 91daaf2a..09af11d6 100644
--- a/packages/evmcrispr/src/modules/aragonos/commands/upgrade.ts
+++ b/packages/evmcrispr/src/modules/aragonos/commands/upgrade.ts
@@ -1,11 +1,7 @@
 import { constants, utils } from 'ethers';
 import { isAddress } from 'ethers/lib/utils';
 
-import {
-  ComparisonType,
-  addressesEqual,
-  checkArgsLength,
-} from '../../../utils';
+import { ComparisonType, checkArgsLength } from '../../../utils';
 import type { ICommand } from '../../../types';
 import type { AragonOS } from '../AragonOS';
 import { _aragonEns } from '../helpers/aragonEns';
@@ -83,10 +79,6 @@ export const upgrade: ICommand<AragonOS> = {
       );
     }
 
-    if (addressesEqual(currentAppAddress, newAppAddress)) {
-      throw new ErrorException(`trying to upgrade app to its current version`);
-    }
-
     return [
       {
         to: kernel.address,
diff --git a/packages/evmcrispr/test/modules/aragonos/commands/upgrade.test.ts b/packages/evmcrispr/test/modules/aragonos/commands/upgrade.test.ts
index 8346d8b0..93539c4c 100644
--- a/packages/evmcrispr/test/modules/aragonos/commands/upgrade.test.ts
+++ b/packages/evmcrispr/test/modules/aragonos/commands/upgrade.test.ts
@@ -163,17 +163,4 @@ describe('AragonOS > commands > upgrade <apmRepo> [newAppImplementationAddress]'
 
     await expectThrowAsync(() => interpreter.interpret(), error);
   });
-
-  it('should fail when upgrading an app to the same version', async () => {
-    const interpreter = createAragonScriptInterpreter([
-      'upgrade disputable-conviction-voting.open 1.0.0',
-    ]);
-    const c = findAragonOSCommandNode(interpreter.ast, 'upgrade')!;
-    const error = new CommandError(
-      c,
-      `trying to upgrade app to its current version`,
-    );
-
-    await expectThrowAsync(() => interpreter.interpret(), error);
-  });
 });