Skip to content

Commit

Permalink
Ignore latest memory_profiler version
Browse files Browse the repository at this point in the history
rubocop#13002
SamSaffron/memory_profiler#118

This causes issues in CI since it accidentally added a dependency on base64
The next release will fix that error
  • Loading branch information
Earlopain committed Jun 25, 2024
1 parent 1930f0e commit 04c15b1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ gem 'bundler', '>= 1.15.0', '< 3.0'
# https://github.com/lsegal/yard/pull/1546
# Please remove this dependency when the issue is resolved.
gem 'logger'
gem 'memory_profiler', platform: :mri
gem 'memory_profiler', '!= 1.0.2', platform: :mri
# FIXME: This is a workaround to prevent the following warning in YARD:
# https://github.com/lsegal/yard/pull/1545
# Please remove this dependency when the issue is resolved.
Expand Down
5 changes: 1 addition & 4 deletions spec/rubocop/cli_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2182,10 +2182,7 @@ def method(foo, bar, qux, fred, arg5, f) end #{'#' * 85}
expect(File).to exist(cpu_profile)
end

# FIXME: https://github.com/rubocop/rubocop/actions/runs/9542192514/job/26296594698
# It is necessary to investigate and resolve the error that occurred with Ruby 3.4-dev in
# https://github.com/rubocop/rubocop/pull/12999.
it 'creates memory profile file', broken_on: :ruby_head do
it 'creates memory profile file' do
expect(cli.run(['--profile', '--memory', 'example1.rb'])).to eq(0)
expect($stdout.string).to include('Building memory report...')
expect(File).to exist(memory_profile)
Expand Down

0 comments on commit 04c15b1

Please sign in to comment.