Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated interpreter error and replaced parseExpr with the appropriate allowed expression #419

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

mkarten
Copy link
Member

@mkarten mkarten commented Oct 1, 2024

No description provided.

@mkarten mkarten added the implemented the feature has been implemented label Oct 1, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.74%. Comparing base (e4455f6) to head (ce67ecc).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
interpreter/expr.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   87.72%   87.74%   +0.02%     
==========================================
  Files          38       38              
  Lines        5603     5613      +10     
==========================================
+ Hits         4915     4925      +10     
  Misses        557      557              
  Partials      131      131              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkarten mkarten assigned mkarten and unassigned Sanegv, tot0p, mkarten and Axou89 Oct 2, 2024
Copy link
Member

@Sanegv Sanegv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Unit Tests should be split in smaller parts, and have more explicit error messages, but I don't see a real issue with the code

@mkarten mkarten merged commit bed1b47 into main Oct 2, 2024
2 checks passed
@mkarten mkarten deleted the issue-#418-calling-lib-function-error branch October 2, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implemented the feature has been implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling a lib function of accessing field inside a binary expression causses an error
4 participants