-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain function Max_Rootdepth #176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EntingTang Thanks for your effort. Please see my comments in the code.
@EntingTang @Crystal-szj Hi, are you still working on this pull request? can you please fix the conflict and finalize the pull request? so it can be merged after that. If you need help with fixing the "merge conflict", let me know. |
274494d
to
9c5bb40
Compare
Hi @SarahAlidoost, I've fixed the conflict and compared the results using compare_git_branch_results.ipynb. The results are same. Thus, the changes for the I'm wondering if it is beneficial to push the comparison results as well. Currently, I am encountering an issue with the passphrase on my local computer, so I haven't been able to push the results yet. |
Thanks for fixing the pull request. no need to run the test notebook or re-generate the exe file because the changes are about adding comments only. Feel free to merge. |
Description
Please add a description of the changes proposed in the pull request.
Update executable file
Please re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.
Checklist
closes #164