revise strings comparison in src/+parameters/loadParameters.m

[Crystal-szj]

Description

This pull request is used to revise the function for comparing two strings in loadParameters.m. The modification aims to enable STEMMUS-SCOPE to throw warming messages under the following conditions:

1. variables defined in ScopeParameters are not found at the input_data.xlsx,
2. extra parameters are added in ScopeParameters.

This modification will not change the outputs of STEMMUS-SCOPE.

Checklist

• Add a reference to related issues.
• @mentions of the person or team responsible for reviewing proposed changes.
• This pull request has a descriptive title.
• Code is written according to the guidelines.
• The checks by MISS_HIT style checker and linter, below the pull request, are successful (green).
• Documentation is available.
• Add changes to the changelog file under section Unreleased.
• Model runs successfully.
• Ask a meinatainer to re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

closes #248

[Crystal-szj]

Hi @SarahAlidoost, could you please help to review this pull request?

[MostafaGomaa93]

Hi @Crystal-szj, I have also checked your PR and it looks fine. You mainly change the sign (==) with the strcmp() method for string comparison. Maybe one thing if you could help clarify, what was the reason of the error message in the related issue 248?

[Crystal-szj]

Hi @Crystal-szj, I have also checked your PR and it looks fine. You mainly change the sign (==) with the strcmp() method for string comparison. Maybe one thing if you could help clarify, what was the reason of the error message in the related issue 248?

Hi @MostafaGomaa93 thanks a lot for your help and reviewing.
The issue #248 is used to check if the variables defined in ScopeParametersNames are initialized in the input_data.xlsx file.

STEMMUS_SCOPE/src/+parameters/loadParameters.m

Lines 7 to 16 in 8cce9c6

	ScopeParametersNames = {
	'Cab', 'Cca', 'Cdm', 'Cw', 'Cs', 'N', 'rho_thermal', 'tau_thermal', ...
	'Vcmo', 'm', 'Type', 'kV', 'Rdparam', 'Tparam', 'fqe', 'spectrum', ...
	'rss', 'rs_thermal', 'cs', 'rhos', 'lambdas', 'LAI', 'hc', 'zo', 'd', ...
	'LIDFa', 'LIDFb', 'leafwidth', 'z', 'Rin', 'Ta', 'Rli', 'p', 'ea', 'u', ...
	'Ca', 'Oa', 'rb', 'Cd', 'CR', 'CD1', 'Psicor', 'CSSOIL', 'rbs', 'rwc', ...
	'startDOY', 'endDOY', 'LAT', 'LON', 'timezn', 'tts', 'tto', 'psi', 'SMC', ...
	'Tyear', 'beta', 'kNPQs', 'qLs', 'stressfactor', 'Cant', 'BSMBrightness', ...
	'BSMlat', 'BSMlon', 'BallBerry0'
	};

For example, if we add one parameter named g1 in ScopeParametersNames in the code, but don't add it in the input_data.xlsx file, or we only add g1 in the input_data.xlsx but without setting an initial value for it, there should be a warming message to remind us to set an initial value for the newly added variable g1.

[SarahAlidoost]

Hi @SarahAlidoost, could you please help to review this pull request?

@Crystal-szj Thanks for the fixes, please go ahead with merging. 👍