Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused types warnings #82

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Fix unused types warnings #82

merged 2 commits into from
Jul 6, 2023

Conversation

cossio
Copy link
Contributor

@cossio cossio commented Jul 6, 2023

Attempt to fix #81

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5474312604

  • 1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.8%) to 58.165%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/plot.jl 0 1 0.0%
Totals Coverage Status
Change from base Build 4814055898: -1.8%
Covered Lines: 1268
Relevant Lines: 2180
💛 - Coveralls

@richardreeve
Copy link
Member

Thanks. I think all of these changes are already in #79 as part of the general tidy up that @ejd99 has done, but that inference work is taking a bit of time, so happy to merge them now if you like.

@richardreeve richardreeve self-requested a review July 6, 2023 13:36
richardreeve
richardreeve approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@richardreeve richardreeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I really care about the whitespace edits, but these seem good to me - thanks.

@richardreeve richardreeve merged commit 6645deb into EcoJulia:dev Jul 6, 2023
@cossio
Copy link
Contributor Author

cossio commented Jul 6, 2023

Didn't realize #79 was covering this too. I think it's helpful to merge now just to get rid of the warning for now. And maybe tag a minor release with it

@cossio cossio deleted the type_warn branch July 6, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardreeve richardreeve richardreeve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning about unused type variables during precompilation
3 participants
@cossio @coveralls @richardreeve