Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constructor that takes any IterableTable or DataStream.Source #23

Open
mkborregaard opened this issue Apr 11, 2018 · 5 comments
Open

Comments

@mkborregaard
Copy link
Member

mkborregaard commented Apr 11, 2018

suggested by @kescobo

@kescobo
Copy link
Member

kescobo commented Apr 11, 2018

I was thinking about this in EcoBase, is that repo mothballed for now?

@mkborregaard
Copy link
Member Author

No not at all mothballed but EcoBase just contains abstract types and functions on them - no implementation. A constructor needs the concrete implementation of the type, thus I thought it should go here.

@mkborregaard
Copy link
Member Author

Everything suffers a bit from me being a bit out of circulation as I'm writing a brand new 7-week MSc course starting in 13 days.

@kescobo
Copy link
Member

kescobo commented Apr 11, 2018

Oh I see - that makes sense.

And I didn't mean to impugn your efforts! I understand 💯% I love teaching, but it's a ton of work.

@mkborregaard
Copy link
Member Author

This should use the new Tables interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants