Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

[FEATURE] Remove Github / from User Rankings #135

Closed
1 task done
adityaraute opened this issue Apr 23, 2024 · 3 comments
Closed
1 task done

[FEATURE] Remove Github / from User Rankings #135

adityaraute opened this issue Apr 23, 2024 · 3 comments
Labels
⭐ goal: addition 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet)

Comments

@adityaraute
Copy link
Member

Is this a unique feature?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Is your feature request related to a problem/unavailable functionality? Please describe.

After navigating to the User Rankings we notice that all users have a prefix GitHub /
Since we are using GitHub OAuth, all users will have this title.
I don't see the point of having the same prefix for all users. It would make for a much cleaner UI if this prefix is omitted.

Proposed Solution

When displaying that part of the card, we can simply truncate that part of the string, and display just the username, as is done in the Activity feed. (See screenshot below)

Screenshots

User Rankings page:
image

Activity Feed
image

Do you want to work on this issue?

No

If "yes" to above, please explain how you would technically implement this (issue will not be assigned if this is skipped)

NA

@adityaraute adityaraute added ⭐ goal: addition 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Apr 23, 2024
@Bashamega
Copy link
Member

I would like to work on that.
There is a line that i just need to get rid of

@eddiejaoude
Copy link
Member

Thank you for raising the issue. I would like to keep the prepended github, this was done as part of the design, because in the future we may have other sign in options. So i will close this issue for now

@eddiejaoude eddiejaoude closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2024
Copy link
Contributor

Thank you all for contributing to RepoRater! Please take a moment to rate this repo's DX on EddieHub's RepoRater and give the repo a star ⭐

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⭐ goal: addition 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet)
Projects
None yet
Development

No branches or pull requests

3 participants