Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

Closes#385 <feature-added-in-login-button-#385> #391

Merged

Conversation

pragyamishra56
Copy link
Contributor

@pragyamishra56 pragyamishra56 commented Oct 21, 2023

Fixes Issue:

Improved user experience: A consistent hover effect across the platform enhances the overall user experience and encourages user engagement.

closes #385

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot 2023-10-21 162335

Note to reviewers

Copy link
Member

@Cahllagerfeld Cahllagerfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bildschirmfoto 2023-10-21 um 19 37 27

For me the orange tones aren't the same. Could you please use the same orange, as we use for the Get-started button.

Same applies for the darkmode hover effect 🤔

Copy link
Contributor Author

@pragyamishra56 pragyamishra56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sir I've made the changes as mentioned, "it seems the orange tones don't match. Could you please use the same orange color that we use for the 'Get Started' button?" If any additional changes are needed, please let me know Sir

Screenshot

Screenshot 2023-10-22 125520

@pragyamishra56
Copy link
Contributor Author

pragyamishra56 commented Oct 24, 2023

@Cahllagerfeld Sir I submitted a pull request with the screenshot three days ago. Could you please review it? If any further improvements are needed, kindly let me know. Thank you for your assistance

Copy link
Member

@Cahllagerfeld Cahllagerfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the last tweak to it, so we can get it merged now 🎉

@Cahllagerfeld Cahllagerfeld merged commit 5d225ff into EddieHubCommunity:main Oct 24, 2023
1 check passed
@pragyamishra56
Copy link
Contributor Author

I made the last tweak to it, so we can get it merged now 🎉

@Cahllagerfeld Sir, thank you so much

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Login Button should be hover like Get started Button
2 participants