This repository has been archived by the owner on Sep 12, 2024. It is now read-only.
Fixes issue #419: Improve app by adding working params and fix the fi… #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ms and fix the filter when switch to github or eddie
|
Hey @Bashamega, please review this |
|
Why did you open a new pr? |
|
@Bashamega, I were unable to remove the package-lock.json file, that is why I opened this new PR but I also closed the previous PR |
No problem. The changes look good. Lets wait until @eddiejaoude merge it |
Bashamega
approved these changes
Sep 1, 2024
|
@Bashamega, Ok thanks |
|
@eddiejaoude, Please review this PR |
He might take time since he has a lot of notifications and work. |
YasirY-ux
approved these changes
Sep 5, 2024
|
@eddiejaoude, please review this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Closes #419
Changes Proposed
Check List (Check all the applicable boxes)
reviewers!!
Please review the updated filter functionality and let me know if any additional changes are needed.