Jon/fix/fio-tx-saved-data #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peachbits
requested changes
Sep 3, 2024
Jon-edge
force-pushed
the
jon/fix/fio-tx-saved-data
branch
7 times, most recently
from
5ba131c
to
3468750
Compare
peachbits
requested changes
Sep 5, 2024
src/fio/FioEngine.ts
Outdated
| @@ -2139,11 +2147,9 @@ export const parseAction = ({ | |||
| networkFee = '0' | |||
| } else { | |||
| networkFee = isRecipient ? `-${fioAmount}` : fioAmount | |||
| networkFee = '0' | |||
There was a problem hiding this comment.
Yeah bad merge conflict resolution, good catch
src/fio/FioEngine.ts
Outdated
| } | ||
|
|
||
| nativeAmount = data.to === actor ? `${fioAmount}` : `-${fioAmount}` |
There was a problem hiding this comment.
I think these two lines should be removed from the previous commit
Jon-edge
force-pushed
the
jon/fix/fio-tx-saved-data
branch
5 times, most recently
from
b2faa3f
to
ca9387b
Compare
peachbits
approved these changes
Sep 5, 2024
Retaining all existing functionality
Previously, unstake txs only stored the reward action amount. Unstake txs now correctly total the reward action amount + unstake amount.
We no longer need to process multiple txs to accurately get fees for sending funds
Jon-edge
force-pushed
the
jon/fix/fio-tx-saved-data
branch
from
8a265c2
to
8526a27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none