Update tx_info request to include inputs #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
requested changes
Sep 5, 2024
samholmes
reviewed
Sep 5, 2024
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ | |||
| - added: (Ethereum/Solana) Support additional tokens provided by info server | |||
| - added: (Thorchain) Add Midgard API for transaction queries | |||
| - changed: (Thorchain) Move most Thorchain-specific functionality out of CosmosEngine and into to ThorchainEngine subclass | |||
| - fixed: Update tx_info request to include inputs | |||
There was a problem hiding this comment.
Add (ADA) to this changelog so it's not so ambiguous
There was a problem hiding this comment.
Why not fixed: (ADA) Update tx_info request to include inputs in order to fix all transactions show as receive bug
peachbits
force-pushed
the
matthew/cardano-inputs
branch
from
a65da87
to
148765b
Compare
samholmes
requested changes
Sep 5, 2024
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ | |||
| - added: (Ethereum/Solana) Support additional tokens provided by info server | |||
| - added: (Thorchain) Add Midgard API for transaction queries | |||
| - changed: (Thorchain) Move most Thorchain-specific functionality out of CosmosEngine and into to ThorchainEngine subclass | |||
| - fixed: Update tx_info request to include inputs | |||
There was a problem hiding this comment.
Why not fixed: (ADA) Update tx_info request to include inputs in order to fix all transactions show as receive bug
peachbits
force-pushed
the
matthew/cardano-inputs
branch
from
148765b
to
f1031f1
Compare
samholmes
approved these changes
Sep 5, 2024
The Koios tx_info endpoint changed and you must now request input data
peachbits
force-pushed
the
matthew/cardano-inputs
branch
from
f1031f1
to
80ce08c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none