Merge duplicate token transaction data from evmscan

[samholmes]

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

• Yes
• No

Dependencies

none

Description

none

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1208217866090168

[paullinator]

Optional change for clarity

[paullinator]

I get it. but this is a good example of high cognitive load to understand. Maybe in the future declare the tx object outside of the .set(), then add the parentNetworkFee to it if needed. Then call the .set() with the tx object

const edgeTransaction: EdgeTransaction =  {
      ...existingTransaction,
      isSend: nativeAmount.startsWith('-'),
      nativeAmount,
      networkFee: mergedNetworkFee,
      ourReceiveAddresses: [
        ...existingTransaction.ourReceiveAddresses,
        ...transaction.ourReceiveAddresses
      ]
}

if (mergedParentNetworkFee != null) {
  edgeTransaction.parentNetworkFee = mergedParentNetworkFee
}

txidToTransaction.set(uniqueKey, edgeTransaction)