Fix FIO amounts in parseAction #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peachbits
changed the title
Jon-edge
requested changes
Sep 16, 2024
src/fio/FioEngine.ts
Outdated
| networkFee = dataMaxFee | ||
| nativeAmount = `-${networkFee}` // Self-transfer should not affect balance |
| } else { | ||
| networkFee = isRecipient ? `-${fioAmount}` : fioAmount | ||
| const isRecipient = data.to === actor | ||
| networkFee = isRecipient ? `0` : fioAmount |
There was a problem hiding this comment.
Optional change: since networkFee is typically dataMaxFee and these are the exceptions, do the assignment at the beginning with a let so there's less to mentally process per case
There was a problem hiding this comment.
Funny, I purposely kept the initial assignment of networkFee to zero and reassigned it close to nativeAmount to make it easier for myself to understand.
peachbits
force-pushed
the
matthew/fioi-stuff
branch
from
6049ae7
to
1feb2a9
Compare
Jon-edge
approved these changes
Sep 16, 2024
A couple things are going on here: Consistently set the networkFee and then include that (instead of Fio variables) in nativeAmount calculation. This revealed some amount issues across a few actions. Confirmed with multiple accounts and CSV exports Remove an existingTx check in trnsfiopubky because those shouldn't have duplicate txids since they are just regular sends. I suspect the only existingTx block used is the unstakefio case but will leave the others
peachbits
force-pushed
the
matthew/fioi-stuff
branch
from
1feb2a9
to
863d621
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none