Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config mrt_ml_mix seems to be unused #126

Open
luou-wen opened this issue Oct 23, 2021 · 1 comment
Open

Config mrt_ml_mix seems to be unused #126

luou-wen opened this issue Oct 23, 2021 · 1 comment

Comments

@luou-wen
Copy link

Hello, I noticed that the config mrt_ml_mix doesn’t seem to be referenced anywhere outside of the config code. I was wondering if this was by design, or if there is a mrt/mile mixed loss that is yet to be implemented.

I would be interested in using / helping develop the feature if possible.

@rsennrich
Copy link
Collaborator

thanks for pointing this out! Yes, this parameter was used in the Theano branch, but hasn't been implemented in the Tensorflow branch. A pull request adding it would be very welcome!

You should be able to implement this in mrt_cost() in mrt_utils.py , making use of the translation probabilities that are stored in cost. There's already code to include the reference in the list of samples (config.mrt_reference), so make use of that, identify the reference, and add its cost to MRTloss (see the Theano implementation for reference:

def mrt_cost(cost, y_mask, options):
).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants