Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Device.Size: iPad mini 6th not handled #134

Open
kunaljaypatel opened this issue Jun 24, 2024 · 1 comment
Open

BUG: Device.Size: iPad mini 6th not handled #134

kunaljaypatel opened this issue Jun 24, 2024 · 1 comment

Comments

@kunaljaypatel
Copy link

kunaljaypatel commented Jun 24, 2024

You have support for .iPadMini6 in the function, getVersion(code: String). But, you don't properly support in size(). It defaults to unknown. You need to add a case for the enum Size for 8.3 inches for the iPad mini 6th gen.

Additionally, the screenHeight switch in your size function needs a case for '1133' for the iPad mini 6th gen.

    static public func size() -> Size {
            let w: Double = Double(UIScreen.main.bounds.width)
            let h: Double = Double(UIScreen.main.bounds.height)
            let screenHeight: Double = max(w, h)

            switch screenHeight {
            ...
            // case: 1133 need to be handled. 
            }
            }
@kishorepran
Copy link
Collaborator

Hello @kunaljaypatel : in recent time many of our fellow developers have added new set of devices. can you please check if this bug still exists. if yes let me know here. I will try to look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants