Default responder

[nhorton]

Hi all,
I have been trying to figure out how to turn off jbuilder as the default responder for JSON and use OJ. Anyone know the incantation?

[ElMassimo]

Hi Noah!

Would you share an example of the controller action, and how you would expect it to work?

Normally, if you use render json: AlbumSerializer.one(album), jbuilder shouldn't interfere.

[nhorton]

@ElMassimo - sorry for the slow reply and thanks for the great gem!

Its not about a conflict. It is that with jbuilder, you can have an action like:

def show
  @mything = blah
end

If it was an HTML request, show.html.erb will get used. And if it was JSON, then show.json.jbuilder will get used. But with oj_serializers out of the box, you have to have an explicit respond_to block to handle the rendering with the serializer. That is what I want to fix - get the oj_serializer used as the default mime handling responder.

[ElMassimo]

This gem does not attempt to infer a serializer for a specific object, as from a maintenance perspective, using serializers implicitly makes it really hard to detect dead code in the long run.

---

If you would like to add this behavior to your app, you could define a default_render method in ApplicationController:

def default_render
  if @json
	render json: "#{@json.class.name}Serializer".constantize.render(@json)
  else
    super
  end
end

you would then use this by setting @json in your controller actions:

def show
  @json = blah
end

You could even play with having one serializer per controller action, with:

render json: "#{controller_name.classify}::#{action_name.classify}Serializer".constantize.render(@json)

Notice that serializers don't lend themselves to the "implicit render" pattern, as you would need to somehow specify which object should be passed to the serializer—unlike views which have access to all instance variables.

[nhorton]

Fair enough. I appreciate the sample code!

…

On Mon, May 15, 2023, 11:46 AM Máximo Mussini ***@***.***> wrote: This gem does not attempt to infer a serializer for a specific object, as from a maintenance perspective, using serializers implicitly makes it really hard to detect dead code in the long run. ------------------------------ If you would like to add this behavior to your app, you could define a default render method in ApplicationController: def default_render if @JSON render json: ***@***.******@***.***) else super endend Notice that serializers don't lend themselves to the "implicit render" pattern, as you would need to somehow specify which object should be passed to the serializer—unlike views which have access to all instance variables. — Reply to this email directly, view it on GitHub <#14 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABR24VJYZUECB6734KAK43XGJTVXANCNFSM6AAAAAAXXJDJDI> . You are receiving this because you authored the thread.Message ID: ***@***.***>