Fix #14 #24
Merged
Fix #14 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bristermitten
commented
Jun 1, 2024
bristermitten
commented
- Fixes the renamer accidentally thinking things are imported when they're not
- Vastly overhauls the E0001 error, with fancy reporting and fix suggestions
…ity for unknown names Fixes issues where names are implicitly imported because other modules imported them. Additionally, significantly improves the quality of error messages related to unknown names, now suggesting typo fixes or imports to add
…ptional_ needed for unit tests to compile (when renaming specific expressions we don't have a whole module)
bristermitten
deleted the
14-renamer-doesnt-seem-to-actually-take-into-account-whether-things-are-imported
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.