Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt proposal API #1092

Closed
LukasKorba opened this issue Feb 29, 2024 · 0 comments · Fixed by #1117
Closed

Adopt proposal API #1092

LukasKorba opened this issue Feb 29, 2024 · 0 comments · Fixed by #1117

Comments

@LukasKorba
Copy link
Collaborator

Adopt this PR

@LukasKorba LukasKorba modified the milestones: Zashi 1.0, iOS Zashi 1.0 Feb 29, 2024
@LukasKorba LukasKorba added the S-in-progress Status: Work is currently in progress on this item. label Feb 29, 2024
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 3, 2024
- TCA sdkSYnchronizer dependency extended with 3 new Proposal APIs
- proposeTransfer tested, works as expected
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 4, 2024
- TCA sdkSYnchronizer dependency extended with 3 new Proposal APIs
- proposeTransfer tested, works as expected
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 5, 2024
- TCA sdkSYnchronizer dependency extended with 3 new Proposal APIs
- proposeTransfer tested, works as expected

[Electric-Coin-Company#1092] Adopt proposal API

- send transaction via new proposal API implemented
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 7, 2024
- TCA sdkSYnchronizer dependency extended with 3 new Proposal APIs
- proposeTransfer tested, works as expected

[Electric-Coin-Company#1092] Adopt proposal API

- send transaction via new proposal API implemented

[Electric-Coin-Company#1092] Adopt proposal API

- code cleaned up and finished
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 7, 2024
- TCA sdkSYnchronizer dependency extended with 3 new Proposal APIs
- proposeTransfer tested, works as expected

[Electric-Coin-Company#1092] Adopt proposal API

- send transaction via new proposal API implemented

[Electric-Coin-Company#1092] Adopt proposal API

- code cleaned up and finished

[Electric-Coin-Company#1092] Adopt proposal API

- unit tests fixed
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 7, 2024
- TCA sdkSYnchronizer dependency extended with 3 new Proposal APIs
- proposeTransfer tested, works as expected

[Electric-Coin-Company#1092] Adopt proposal API

- send transaction via new proposal API implemented

[Electric-Coin-Company#1092] Adopt proposal API

- code cleaned up and finished

[Electric-Coin-Company#1092] Adopt proposal API

- unit tests fixed

[Electric-Coin-Company#1092] Adopt proposal API

- Typical Fee < 0.001 localized and updated in the UI
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 8, 2024
- TCA sdkSYnchronizer dependency extended with 3 new Proposal APIs
- proposeTransfer tested, works as expected

[Electric-Coin-Company#1092] Adopt proposal API

- send transaction via new proposal API implemented

[Electric-Coin-Company#1092] Adopt proposal API

- code cleaned up and finished

[Electric-Coin-Company#1092] Adopt proposal API

- unit tests fixed

[Electric-Coin-Company#1092] Adopt proposal API

- Typical Fee < 0.001 localized and updated in the UI

[Electric-Coin-Company#1092] Adopt proposal API

- awaiting all transaction results with use of new proposal.transactionCount() method
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 11, 2024
- TCA sdkSYnchronizer dependency extended with 3 new Proposal APIs
- proposeTransfer tested, works as expected

[Electric-Coin-Company#1092] Adopt proposal API

- send transaction via new proposal API implemented

[Electric-Coin-Company#1092] Adopt proposal API

- code cleaned up and finished

[Electric-Coin-Company#1092] Adopt proposal API

- unit tests fixed

[Electric-Coin-Company#1092] Adopt proposal API

- Typical Fee < 0.001 localized and updated in the UI

[Electric-Coin-Company#1092] Adopt proposal API

- awaiting all transaction results with use of new proposal.transactionCount() method

[Electric-Coin-Company#1092] Adopt proposal API

- Implemented new PartialProposalError reducer and view
- Contact support mail with transaction IDs logic implemented
- Fallback to share logic implemented
- PPE integrated into SendFlow
- PPE integrated into Shielding
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 11, 2024
- TCA sdkSYnchronizer dependency extended with 3 new Proposal APIs
- proposeTransfer tested, works as expected

[Electric-Coin-Company#1092] Adopt proposal API

- send transaction via new proposal API implemented

[Electric-Coin-Company#1092] Adopt proposal API

- code cleaned up and finished

[Electric-Coin-Company#1092] Adopt proposal API

- unit tests fixed

[Electric-Coin-Company#1092] Adopt proposal API

- Typical Fee < 0.001 localized and updated in the UI

[Electric-Coin-Company#1092] Adopt proposal API

- awaiting all transaction results with use of new proposal.transactionCount() method

[Electric-Coin-Company#1092] Adopt proposal API

- Implemented new PartialProposalError reducer and view
- Contact support mail with transaction IDs logic implemented
- Fallback to share logic implemented
- PPE integrated into SendFlow
- PPE integrated into Shielding

[Electric-Coin-Company#1092] Adopt proposal API

- Changelog updated
@true-jared true-jared added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-in-progress Status: Work is currently in progress on this item. labels Mar 11, 2024
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 12, 2024
- TCA sdkSYnchronizer dependency extended with 3 new Proposal APIs
- proposeTransfer tested, works as expected

[Electric-Coin-Company#1092] Adopt proposal API

- send transaction via new proposal API implemented

[Electric-Coin-Company#1092] Adopt proposal API

- code cleaned up and finished

[Electric-Coin-Company#1092] Adopt proposal API

- unit tests fixed

[Electric-Coin-Company#1092] Adopt proposal API

- Typical Fee < 0.001 localized and updated in the UI

[Electric-Coin-Company#1092] Adopt proposal API

- awaiting all transaction results with use of new proposal.transactionCount() method

[Electric-Coin-Company#1092] Adopt proposal API

- Implemented new PartialProposalError reducer and view
- Contact support mail with transaction IDs logic implemented
- Fallback to share logic implemented
- PPE integrated into SendFlow
- PPE integrated into Shielding

[Electric-Coin-Company#1092] Adopt proposal API

- Changelog updated

[Electric-Coin-Company#1092] Adopt proposal API

- SDK's fee constant removed
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 13, 2024
- TCA sdkSYnchronizer dependency extended with 3 new Proposal APIs
- proposeTransfer tested, works as expected

[Electric-Coin-Company#1092] Adopt proposal API

- send transaction via new proposal API implemented

[Electric-Coin-Company#1092] Adopt proposal API

- code cleaned up and finished

[Electric-Coin-Company#1092] Adopt proposal API

- unit tests fixed

[Electric-Coin-Company#1092] Adopt proposal API

- Typical Fee < 0.001 localized and updated in the UI

[Electric-Coin-Company#1092] Adopt proposal API

- awaiting all transaction results with use of new proposal.transactionCount() method

[Electric-Coin-Company#1092] Adopt proposal API

- Implemented new PartialProposalError reducer and view
- Contact support mail with transaction IDs logic implemented
- Fallback to share logic implemented
- PPE integrated into SendFlow
- PPE integrated into Shielding

[Electric-Coin-Company#1092] Adopt proposal API

- Changelog updated

[Electric-Coin-Company#1092] Adopt proposal API

- SDK's fee constant removed
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 13, 2024
- TCA sdkSYnchronizer dependency extended with 3 new Proposal APIs
- proposeTransfer tested, works as expected

[Electric-Coin-Company#1092] Adopt proposal API

- send transaction via new proposal API implemented

[Electric-Coin-Company#1092] Adopt proposal API

- code cleaned up and finished

[Electric-Coin-Company#1092] Adopt proposal API

- unit tests fixed

[Electric-Coin-Company#1092] Adopt proposal API

- Typical Fee < 0.001 localized and updated in the UI

[Electric-Coin-Company#1092] Adopt proposal API

- awaiting all transaction results with use of new proposal.transactionCount() method

[Electric-Coin-Company#1092] Adopt proposal API

- Implemented new PartialProposalError reducer and view
- Contact support mail with transaction IDs logic implemented
- Fallback to share logic implemented
- PPE integrated into SendFlow
- PPE integrated into Shielding

[Electric-Coin-Company#1092] Adopt proposal API

- Changelog updated

[Electric-Coin-Company#1092] Adopt proposal API

- SDK's fee constant removed

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- debug code reverted
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 13, 2024
- TCA sdkSYnchronizer dependency extended with 3 new Proposal APIs
- proposeTransfer tested, works as expected

[Electric-Coin-Company#1092] Adopt proposal API

- send transaction via new proposal API implemented

[Electric-Coin-Company#1092] Adopt proposal API

- code cleaned up and finished

[Electric-Coin-Company#1092] Adopt proposal API

- unit tests fixed

[Electric-Coin-Company#1092] Adopt proposal API

- Typical Fee < 0.001 localized and updated in the UI

[Electric-Coin-Company#1092] Adopt proposal API

- awaiting all transaction results with use of new proposal.transactionCount() method

[Electric-Coin-Company#1092] Adopt proposal API

- Implemented new PartialProposalError reducer and view
- Contact support mail with transaction IDs logic implemented
- Fallback to share logic implemented
- PPE integrated into SendFlow
- PPE integrated into Shielding

[Electric-Coin-Company#1092] Adopt proposal API

- Changelog updated

[Electric-Coin-Company#1092] Adopt proposal API

- SDK's fee constant removed

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- debug code reverted

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- copy change
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 13, 2024
- TCA sdkSYnchronizer dependency extended with 3 new Proposal APIs
- proposeTransfer tested, works as expected

[Electric-Coin-Company#1092] Adopt proposal API

- send transaction via new proposal API implemented

[Electric-Coin-Company#1092] Adopt proposal API

- code cleaned up and finished

[Electric-Coin-Company#1092] Adopt proposal API

- unit tests fixed

[Electric-Coin-Company#1092] Adopt proposal API

- Typical Fee < 0.001 localized and updated in the UI

[Electric-Coin-Company#1092] Adopt proposal API

- awaiting all transaction results with use of new proposal.transactionCount() method

[Electric-Coin-Company#1092] Adopt proposal API

- Implemented new PartialProposalError reducer and view
- Contact support mail with transaction IDs logic implemented
- Fallback to share logic implemented
- PPE integrated into SendFlow
- PPE integrated into Shielding

[Electric-Coin-Company#1092] Adopt proposal API

- Changelog updated

[Electric-Coin-Company#1092] Adopt proposal API

- SDK's fee constant removed

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- debug code reverted

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- copy change

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- code cleanup
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 13, 2024
- TCA sdkSYnchronizer dependency extended with 3 new Proposal APIs
- proposeTransfer tested, works as expected

[Electric-Coin-Company#1092] Adopt proposal API

- send transaction via new proposal API implemented

[Electric-Coin-Company#1092] Adopt proposal API

- code cleaned up and finished

[Electric-Coin-Company#1092] Adopt proposal API

- unit tests fixed

[Electric-Coin-Company#1092] Adopt proposal API

- Typical Fee < 0.001 localized and updated in the UI

[Electric-Coin-Company#1092] Adopt proposal API

- awaiting all transaction results with use of new proposal.transactionCount() method

[Electric-Coin-Company#1092] Adopt proposal API

- Implemented new PartialProposalError reducer and view
- Contact support mail with transaction IDs logic implemented
- Fallback to share logic implemented
- PPE integrated into SendFlow
- PPE integrated into Shielding

[Electric-Coin-Company#1092] Adopt proposal API

- Changelog updated

[Electric-Coin-Company#1092] Adopt proposal API

- SDK's fee constant removed

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- debug code reverted

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- copy change

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- code cleanup
@true-jared true-jared removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 13, 2024
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 14, 2024
- TCA sdkSYnchronizer dependency extended with 3 new Proposal APIs
- proposeTransfer tested, works as expected

[Electric-Coin-Company#1092] Adopt proposal API

- send transaction via new proposal API implemented

[Electric-Coin-Company#1092] Adopt proposal API

- code cleaned up and finished

[Electric-Coin-Company#1092] Adopt proposal API

- unit tests fixed

[Electric-Coin-Company#1092] Adopt proposal API

- Typical Fee < 0.001 localized and updated in the UI

[Electric-Coin-Company#1092] Adopt proposal API

- awaiting all transaction results with use of new proposal.transactionCount() method

[Electric-Coin-Company#1092] Adopt proposal API

- Implemented new PartialProposalError reducer and view
- Contact support mail with transaction IDs logic implemented
- Fallback to share logic implemented
- PPE integrated into SendFlow
- PPE integrated into Shielding

[Electric-Coin-Company#1092] Adopt proposal API

- Changelog updated

[Electric-Coin-Company#1092] Adopt proposal API

- SDK's fee constant removed

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- debug code reverted

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- copy change

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- code cleanup

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- proposed total fee
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 14, 2024
- TCA sdkSYnchronizer dependency extended with 3 new Proposal APIs
- proposeTransfer tested, works as expected

[Electric-Coin-Company#1092] Adopt proposal API

- send transaction via new proposal API implemented

[Electric-Coin-Company#1092] Adopt proposal API

- code cleaned up and finished

[Electric-Coin-Company#1092] Adopt proposal API

- unit tests fixed

[Electric-Coin-Company#1092] Adopt proposal API

- Typical Fee < 0.001 localized and updated in the UI

[Electric-Coin-Company#1092] Adopt proposal API

- awaiting all transaction results with use of new proposal.transactionCount() method

[Electric-Coin-Company#1092] Adopt proposal API

- Implemented new PartialProposalError reducer and view
- Contact support mail with transaction IDs logic implemented
- Fallback to share logic implemented
- PPE integrated into SendFlow
- PPE integrated into Shielding

[Electric-Coin-Company#1092] Adopt proposal API

- Changelog updated

[Electric-Coin-Company#1092] Adopt proposal API

- SDK's fee constant removed

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- debug code reverted

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- copy change

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- code cleanup

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- proposed total fee
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 19, 2024
- TCA sdkSYnchronizer dependency extended with 3 new Proposal APIs
- proposeTransfer tested, works as expected

[Electric-Coin-Company#1092] Adopt proposal API

- send transaction via new proposal API implemented

[Electric-Coin-Company#1092] Adopt proposal API

- code cleaned up and finished

[Electric-Coin-Company#1092] Adopt proposal API

- unit tests fixed

[Electric-Coin-Company#1092] Adopt proposal API

- Typical Fee < 0.001 localized and updated in the UI

[Electric-Coin-Company#1092] Adopt proposal API

- awaiting all transaction results with use of new proposal.transactionCount() method

[Electric-Coin-Company#1092] Adopt proposal API

- Implemented new PartialProposalError reducer and view
- Contact support mail with transaction IDs logic implemented
- Fallback to share logic implemented
- PPE integrated into SendFlow
- PPE integrated into Shielding

[Electric-Coin-Company#1092] Adopt proposal API

- Changelog updated

[Electric-Coin-Company#1092] Adopt proposal API

- SDK's fee constant removed

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- debug code reverted

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- copy change

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- code cleanup

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- proposed total fee
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 19, 2024
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 19, 2024
- TCA sdkSYnchronizer dependency extended with 3 new Proposal APIs
- proposeTransfer tested, works as expected

[Electric-Coin-Company#1092] Adopt proposal API

- send transaction via new proposal API implemented

[Electric-Coin-Company#1092] Adopt proposal API

- code cleaned up and finished

[Electric-Coin-Company#1092] Adopt proposal API

- unit tests fixed

[Electric-Coin-Company#1092] Adopt proposal API

- Typical Fee < 0.001 localized and updated in the UI

[Electric-Coin-Company#1092] Adopt proposal API

- awaiting all transaction results with use of new proposal.transactionCount() method

[Electric-Coin-Company#1092] Adopt proposal API

- Implemented new PartialProposalError reducer and view
- Contact support mail with transaction IDs logic implemented
- Fallback to share logic implemented
- PPE integrated into SendFlow
- PPE integrated into Shielding

[Electric-Coin-Company#1092] Adopt proposal API

- Changelog updated

[Electric-Coin-Company#1092] Adopt proposal API

- SDK's fee constant removed

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- debug code reverted

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- copy change

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- code cleanup

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- proposed total fee

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- Final copy
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 20, 2024
- TCA sdkSYnchronizer dependency extended with 3 new Proposal APIs
- proposeTransfer tested, works as expected

[Electric-Coin-Company#1092] Adopt proposal API

- send transaction via new proposal API implemented

[Electric-Coin-Company#1092] Adopt proposal API

- code cleaned up and finished

[Electric-Coin-Company#1092] Adopt proposal API

- unit tests fixed

[Electric-Coin-Company#1092] Adopt proposal API

- Typical Fee < 0.001 localized and updated in the UI

[Electric-Coin-Company#1092] Adopt proposal API

- awaiting all transaction results with use of new proposal.transactionCount() method

[Electric-Coin-Company#1092] Adopt proposal API

- Implemented new PartialProposalError reducer and view
- Contact support mail with transaction IDs logic implemented
- Fallback to share logic implemented
- PPE integrated into SendFlow
- PPE integrated into Shielding

[Electric-Coin-Company#1092] Adopt proposal API

- Changelog updated

[Electric-Coin-Company#1092] Adopt proposal API

- SDK's fee constant removed

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- debug code reverted

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- copy change

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- code cleanup

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- proposed total fee

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- Final copy

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- Transaction statuses added
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 20, 2024
- TCA sdkSYnchronizer dependency extended with 3 new Proposal APIs
- proposeTransfer tested, works as expected

[Electric-Coin-Company#1092] Adopt proposal API

- send transaction via new proposal API implemented

[Electric-Coin-Company#1092] Adopt proposal API

- code cleaned up and finished

[Electric-Coin-Company#1092] Adopt proposal API

- unit tests fixed

[Electric-Coin-Company#1092] Adopt proposal API

- Typical Fee < 0.001 localized and updated in the UI

[Electric-Coin-Company#1092] Adopt proposal API

- awaiting all transaction results with use of new proposal.transactionCount() method

[Electric-Coin-Company#1092] Adopt proposal API

- Implemented new PartialProposalError reducer and view
- Contact support mail with transaction IDs logic implemented
- Fallback to share logic implemented
- PPE integrated into SendFlow
- PPE integrated into Shielding

[Electric-Coin-Company#1092] Adopt proposal API

- Changelog updated

[Electric-Coin-Company#1092] Adopt proposal API

- SDK's fee constant removed

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- debug code reverted

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- copy change

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- code cleanup

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- proposed total fee

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- Final copy

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- Transaction statuses added

[Electric-Coin-Company#1092] Adopt proposal API (Electric-Coin-Company#1117)

- tests fixed
LukasKorba added a commit that referenced this issue Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants