Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1363] Binary address book serialization #1364

Conversation

LukasKorba
Copy link
Collaborator

Closes #1363

  • Local storage for address book is now primary source of data
  • Remote storage for address book is used as a backup, syncing is prepared and merge strategy is WIP
  • The data serialization/deserialization is prepared, no encryption in place
  • The data are versioned and checked
  • lastUpdated data are stored as well
  • Keychain stores a struct for encryption, in case there is more than just 1 key

This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.

Author

  • Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
  • Does the code abide by the Coding Guidelines?
  • Automated tests: Did you add appropriate automated tests for any code changes?
  • Code coverage: Did you check the code coverage report for the automated tests? While we are not looking for perfect coverage, the tool can point out potential cases that have been missed.
  • Documentation: Did you update Docs as appropiate? (E.g README.md, etc.)
  • Run the app: Did you run the app and try the changes?
  • Did you provide Screenshots of what the App looks like before and after your changes as part of the description of this PR? (only applicable to UI Changes)
  • Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

  • Checklist review: Did you go through the code with the Code Review Guidelines checklist?
  • Ad hoc review: Did you perform an ad hoc review? In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
  • Automated tests: Did you review the automated tests?
  • Manual tests: Did you review the manual tests?You will find manual testing guidelines under our manual testing section
  • How is Code Coverage affected by this PR? We encourage you to compare coverage before and after your changes and when possible, leave it in a better place. Learn More...
  • Documentation: Did you review Docs, README.md, LICENSE.md, and Architecture.md as appropriate?
  • Run the app: Did you run the app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data.

@LukasKorba LukasKorba marked this pull request as ready for review September 30, 2024 09:18
@LukasKorba LukasKorba force-pushed the 1363-Binary-address-book-serialization branch from 85a8eec to 525d235 Compare October 2, 2024 11:56
@LukasKorba LukasKorba added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 3, 2024
@LukasKorba LukasKorba force-pushed the 1363-Binary-address-book-serialization branch from 525d235 to 1ef0234 Compare October 3, 2024 16:00
- Local storage for address book is now primary source of data
- Remote storage for address book is used as a backup, syncing is prepared and merge strategy is WIP
- The data serialization/deserialization is prepared, no encryption in place
- The data are versioned and checked
- lastUpdated data are stored as well
- Keychain stores a struct for encryption, in case there is more than just 1 key

[Electric-Coin-Company#1363] Binary address book serialization

- Subject cleanup

[Electric-Coin-Company#1363] Binary address book serialization

- padding of the currency field fixed
@LukasKorba LukasKorba force-pushed the 1363-Binary-address-book-serialization branch from 1ef0234 to a85c749 Compare October 3, 2024 16:29
@LukasKorba LukasKorba merged commit c90939d into Electric-Coin-Company:release-1.2.2-preview Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants