-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1475] Adopt transaction data requests #1476
Merged
LukasKorba
merged 3 commits into
Electric-Coin-Company:ffi-0.9.0-integration
from
LukasKorba:1475-Adopt-transaction-data-requests
Aug 20, 2024
Merged
[#1475] Adopt transaction data requests #1476
LukasKorba
merged 3 commits into
Electric-Coin-Company:ffi-0.9.0-integration
from
LukasKorba:1475-Adopt-transaction-data-requests
Aug 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasKorba
force-pushed
the
1475-Adopt-transaction-data-requests
branch
6 times, most recently
from
August 18, 2024 17:18
dfbcd78
to
4dc0b2e
Compare
- RustBackend extended for the new 2 rust methods 'transactionDataRequests' and 'setTransactionStatus' - lightwalletservice extended to add a new method 'getTaddressTxids' - Enhance action has been refactored to handle transactionDataRequests [Electric-Coin-Company#1475] Adopt transaction data requests - fixes [Electric-Coin-Company#1475] Adopt transaction data requests - Error codes for specific rust and service errors defined - Fix for the txId [Electric-Coin-Company#1475] Adopt transaction data requests - Checkpoints added - Code cleanup [Electric-Coin-Company#1475] Adopt transaction data requests - bugfixes in the ffi [Electric-Coin-Company#1475] Adopt transaction data requests - FFI with fixes [Electric-Coin-Company#1475] Adopt transaction data requests - Another FFI update with fixes, this time the final [Electric-Coin-Company#1475] Adopt transaction data requests - Fix for the not recognized state of the transaction for FetchTransaction(txId:) [Electric-Coin-Company#1475] Adopt transaction data requests - Code cleaned up and polished [Electric-Coin-Company#1475] Adopt transaction data requests - Changelog updated [Electric-Coin-Company#1475] Adopt transaction data requests - DemoApp settings reverted
LukasKorba
force-pushed
the
1475-Adopt-transaction-data-requests
branch
from
August 18, 2024 17:20
4dc0b2e
to
35c31a4
Compare
nuttycom
reviewed
Aug 19, 2024
LukasKorba
force-pushed
the
1475-Adopt-transaction-data-requests
branch
6 times, most recently
from
August 19, 2024 18:37
efba4df
to
e6a313e
Compare
- Refactor of the logic based on the review, the determination of the calls can't be based on block height but actual response from grpc [Electric-Coin-Company#1475] Adopt transaction data requests - fixes [Electric-Coin-Company#1475] Adopt transaction data requests - Changes made on pairing call [Electric-Coin-Company#1475] Adopt transaction data requests - fixes [Electric-Coin-Company#1475] Adopt transaction data requests - code cleanup [Electric-Coin-Company#1475] Adopt transaction data requests - FFI bumped to the latest version with fixes [Electric-Coin-Company#1475] Adopt transaction data requests - comments removed [Electric-Coin-Company#1475] Adopt transaction data requests - endHeight for spendsFromAddress reduced by 1
LukasKorba
force-pushed
the
1475-Adopt-transaction-data-requests
branch
from
August 19, 2024 18:57
e6a313e
to
e5e1fdf
Compare
nuttycom
requested changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only problem I see is the Int64
being used for the address request end height.
LukasKorba
force-pushed
the
1475-Adopt-transaction-data-requests
branch
4 times, most recently
from
August 20, 2024 20:01
f25c714
to
8283594
Compare
LukasKorba
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Aug 20, 2024
- SpendsFromAddress endHeight is an optional UInt32 [Electric-Coin-Company#1475] Adopt transaction data requests - ignoring the getSubtreeRoots error for now so I can test tex send [Electric-Coin-Company#1475] Adopt transaction data requests - ignoring error of getSubtreeRoots [Electric-Coin-Company#1475] Adopt transaction data requests - reverting the DemoAppConfig [Electric-Coin-Company#1475] Adopt transaction data requests - FFI dependency set to 0.9.0 [Electric-Coin-Company#1475] Adopt transaction data requests - Handling of unknown (code 2) errors as a workaround
LukasKorba
force-pushed
the
1475-Adopt-transaction-data-requests
branch
from
August 20, 2024 20:12
8283594
to
ad30b24
Compare
nuttycom
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK ad30b24
LukasKorba
merged commit Aug 20, 2024
6c51ed9
into
Electric-Coin-Company:ffi-0.9.0-integration
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1475
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author
Reviewer