Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1475] Adopt transaction data requests #1476

Conversation

LukasKorba
Copy link
Collaborator

@LukasKorba LukasKorba commented Aug 16, 2024

Closes #1475

  • RustBackend extended for the new 2 rust methods 'transactionDataRequests' and 'setTransactionStatus'
  • lightwalletservice extended to add a new method 'getTaddressTxids'
  • Enhance action has been refactored to handle transactionDataRequests
  • Error codes for specific rust and service errors defined
  • Checkpoints added
  • Code cleanup

This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.

Author

  • Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
  • Automated tests: Did you add appropriate automated tests for any code changes?
  • Code coverage: Did you check the code coverage report for the automated tests? While we are not looking for perfect coverage, the tool can point out potential cases that have been missed.
  • Documentation: Did you update Docs as appropiate? (E.g README.md, etc.)
  • Run the app: Did you run the app and try the changes?
  • Did you provide Screenshots of what the App looks like before and after your changes as part of the description of this PR? (only applicable to UI Changes)
  • Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

  • Checklist review: Did you go through the code with the Code Review Guidelines checklist?
  • Ad hoc review: Did you perform an ad hoc review? In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
  • Automated tests: Did you review the automated tests?
  • Manual tests: Did you review the manual tests?You will find manual testing guidelines under our manual testing section
  • How is Code Coverage affected by this PR? We encourage you to compare coverage befor and after your changes and when possible, leave it in a better place. Learn More...
  • Documentation: Did you review Docs, README.md, LICENSE.md, and Architecture.md as appropriate?
  • Run the app: Did you run the app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data.

@LukasKorba LukasKorba marked this pull request as draft August 16, 2024 14:53
@LukasKorba LukasKorba force-pushed the 1475-Adopt-transaction-data-requests branch 6 times, most recently from dfbcd78 to 4dc0b2e Compare August 18, 2024 17:18
- RustBackend extended for the new 2 rust methods 'transactionDataRequests' and 'setTransactionStatus'
- lightwalletservice extended to add a new method 'getTaddressTxids'
- Enhance action has been refactored to handle transactionDataRequests

[Electric-Coin-Company#1475] Adopt transaction data requests

- fixes

[Electric-Coin-Company#1475] Adopt transaction data requests

- Error codes for specific rust and service errors defined
- Fix for the txId

[Electric-Coin-Company#1475] Adopt transaction data requests

- Checkpoints added
- Code cleanup

[Electric-Coin-Company#1475] Adopt transaction data requests

- bugfixes in the ffi

[Electric-Coin-Company#1475] Adopt transaction data requests

- FFI with fixes

[Electric-Coin-Company#1475] Adopt transaction data requests

- Another FFI update with fixes, this time the final

[Electric-Coin-Company#1475] Adopt transaction data requests

- Fix for the not recognized state of the transaction for FetchTransaction(txId:)

[Electric-Coin-Company#1475] Adopt transaction data requests

- Code cleaned up and polished

[Electric-Coin-Company#1475] Adopt transaction data requests

- Changelog updated

[Electric-Coin-Company#1475] Adopt transaction data requests

- DemoApp settings reverted
@LukasKorba LukasKorba force-pushed the 1475-Adopt-transaction-data-requests branch from 4dc0b2e to 35c31a4 Compare August 18, 2024 17:20
@LukasKorba LukasKorba force-pushed the 1475-Adopt-transaction-data-requests branch 6 times, most recently from efba4df to e6a313e Compare August 19, 2024 18:37
- Refactor of the logic based on the review, the determination of the calls can't be based on block height but actual response from grpc

[Electric-Coin-Company#1475] Adopt transaction data requests

- fixes

[Electric-Coin-Company#1475] Adopt transaction data requests

- Changes made on pairing call

[Electric-Coin-Company#1475] Adopt transaction data requests

- fixes

[Electric-Coin-Company#1475] Adopt transaction data requests

- code cleanup

[Electric-Coin-Company#1475] Adopt transaction data requests

- FFI bumped to the latest version with fixes

[Electric-Coin-Company#1475] Adopt transaction data requests

- comments removed

[Electric-Coin-Company#1475] Adopt transaction data requests

- endHeight for spendsFromAddress reduced by 1
@LukasKorba LukasKorba force-pushed the 1475-Adopt-transaction-data-requests branch from e6a313e to e5e1fdf Compare August 19, 2024 18:57
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only problem I see is the Int64 being used for the address request end height.

@LukasKorba LukasKorba force-pushed the 1475-Adopt-transaction-data-requests branch 4 times, most recently from f25c714 to 8283594 Compare August 20, 2024 20:01
@LukasKorba LukasKorba marked this pull request as ready for review August 20, 2024 20:02
@LukasKorba LukasKorba added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2024
- SpendsFromAddress endHeight is an optional UInt32

[Electric-Coin-Company#1475] Adopt transaction data requests

- ignoring the getSubtreeRoots error for now so I can test tex send

[Electric-Coin-Company#1475] Adopt transaction data requests

- ignoring error of getSubtreeRoots

[Electric-Coin-Company#1475] Adopt transaction data requests

- reverting the DemoAppConfig

[Electric-Coin-Company#1475] Adopt transaction data requests

- FFI dependency set to 0.9.0

[Electric-Coin-Company#1475] Adopt transaction data requests

- Handling of unknown (code 2) errors as a workaround
@LukasKorba LukasKorba force-pushed the 1475-Adopt-transaction-data-requests branch from 8283594 to ad30b24 Compare August 20, 2024 20:12
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK ad30b24

@LukasKorba LukasKorba merged commit 6c51ed9 into Electric-Coin-Company:ffi-0.9.0-integration Aug 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants